Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Set explicit encoding in setup.py #709

Merged
merged 3 commits into from
Jan 26, 2021
Merged

[Bug] Set explicit encoding in setup.py #709

merged 3 commits into from
Jan 26, 2021

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jan 4, 2021

Description

On the GPU Cluster, setup.py uses the wrong encoding when reading README.md which contains umlauts. This PR sets it explicitly to UTF-8.

Changes proposed:

  • explicit encoding in setup.py

Type of change

Bug fix

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar added bug Something isn't working documentation Anything related to documentation testing Implementation of tests, or test-related issues labels Jan 4, 2021
@mtar mtar changed the title explecitly set encoding explicit citset encoding Jan 4, 2021
@mtar mtar changed the title explicit citset encoding [Bug] Explicit set encoding in setup.py Jan 4, 2021
@mtar mtar changed the title [Bug] Explicit set encoding in setup.py [Bug] Set explicit encoding in setup.py Jan 5, 2021
bhagemeier
bhagemeier approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@bhagemeier bhagemeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mtar mtar merged commit 2d1b846 into master Jan 26, 2021
@mtar mtar deleted the bug/reading-setup branch January 26, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhagemeier bhagemeier bhagemeier approved these changes

@coquelin77 coquelin77 Awaiting requested review from coquelin77

@ClaudiaComito ClaudiaComito Awaiting requested review from ClaudiaComito

@Markus-Goetz Markus-Goetz Awaiting requested review from Markus-Goetz

Assignees
No one assigned
Labels
bug Something isn't working documentation Anything related to documentation testing Implementation of tests, or test-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtar @bhagemeier @coquelin77