Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix arange float & tests devices #638

Merged
merged 5 commits into from
Jul 28, 2020

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jul 21, 2020

Description

Issue/s resolved: None

Changes proposed:

  • fix dtype of returned DNDarray in arange
  • remove old HEAT_TEST_DEVICE values in test_devices

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

Copy link
Member

@Markus-Goetz Markus-Goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes seem fine to me, however, the tests are not passing with a float32 != int32 assertion exception

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files          85       85           
  Lines       16636    16636           
=======================================
  Hits        16204    16204           
  Misses        432      432           
Impacted Files Coverage Δ
heat/core/factories.py 100.00% <100.00%> (ø)
heat/core/tests/test_devices.py 58.18% <100.00%> (ø)
heat/core/tests/test_factories.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20f14a...ff3dbc0. Read the comment docs.

@Markus-Goetz Markus-Goetz merged commit 9b1f28b into master Jul 28, 2020
@Markus-Goetz Markus-Goetz deleted the bug/factories_and_testdevice branch July 28, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants