Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ht.shape() #600

Merged
merged 2 commits into from
Jun 22, 2020
Merged

ht.shape() #600

merged 2 commits into from
Jun 22, 2020

Conversation

ClaudiaComito
Copy link
Contributor

Description

Analog to our DNDarray method shape and to numpy.shape()

Issue/s resolved: #549

Changes proposed:

  • Added function manipulations.shape()
  • Added tests
  • Updated changelog.

Type of change

  • New feature (non-breaking change which adds functionality)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions - NO, irrelevant
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@ClaudiaComito ClaudiaComito changed the title ht.shape(x) ht.shape() Jun 18, 2020
@ClaudiaComito ClaudiaComito requested a review from coquelin77 June 18, 2020 15:05
@ClaudiaComito
Copy link
Contributor Author

@coquelin77 hey, thanks for the questions but it was faster to implement this one than to write about it.

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #600 into master will increase coverage by 0.93%.
The diff coverage is 98.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
+ Coverage   96.48%   97.41%   +0.93%     
==========================================
  Files          75       75              
  Lines       15276    15030     -246     
==========================================
- Hits        14739    14642      -97     
+ Misses        537      388     -149     
Impacted Files Coverage Δ
heat/core/tests/test_suites/basic_test.py 91.34% <57.14%> (-8.66%) ⬇️
heat/core/linalg/tests/test_qr.py 71.42% <66.66%> (+2.42%) ⬆️
heat/core/tests/test_devices.py 58.18% <79.41%> (-6.64%) ⬇️
heat/core/tests/test_io.py 93.05% <92.45%> (+1.50%) ⬆️
heat/cluster/tests/test_kmeans.py 100.00% <100.00%> (+10.41%) ⬆️
heat/cluster/tests/test_spectral.py 100.00% <100.00%> (+10.63%) ⬆️
heat/core/linalg/tests/test_basics.py 100.00% <100.00%> (+0.61%) ⬆️
heat/core/linalg/tests/test_solver.py 100.00% <100.00%> (+15.15%) ⬆️
heat/core/manipulations.py 99.51% <100.00%> (+<0.01%) ⬆️
heat/core/operations.py 92.73% <100.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42bf442...95e9e79. Read the comment docs.

@Markus-Goetz Markus-Goetz merged commit 4e3cb00 into master Jun 22, 2020
@Markus-Goetz Markus-Goetz deleted the features/549-shape branch June 22, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement shape()
2 participants