tolist() implementation #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
==========================================
- Coverage 96.49% 96.48% -0.01%
==========================================
Files 75 75
Lines 15249 15233 -16
==========================================
- Hits 14714 14698 -16
Misses 535 535
Continue to review full report at Codecov.
|
Markus-Goetz
requested changes
Jun 9, 2020
heat/core/dndarray.py
Outdated
| @@ -3479,6 +3479,33 @@ def tanh(self, out=None): | |||
| """ | |||
| return trigonometrics.tanh(self, out) | |||
|
|
|||
| def tolist(self): | |||
There was a problem hiding this comment.
Return type annotation, remove the return category
…cs/heat into enhancement/579-tolist
…cs/heat into enhancement/579-tolist
Markus-Goetz
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue/s resolved: #579
Implentation of tolist() method for DNDarray class. Returns a copy of the DNDarray as a python list.
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no