Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/35 fliplr #580

Merged
merged 5 commits into from
Jun 4, 2020
Merged

Features/35 fliplr #580

merged 5 commits into from
Jun 4, 2020

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Jun 4, 2020

Description

  • Added function ht.fliplr(), corresponding to ht.flip(a, 1).
  • Implemented tests, including for a.ndim < 2

Issue/s resolved: #35

Changes proposed:

Type of change

New feature (non-breaking change which adds functionality)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #580 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   96.46%   96.47%           
=======================================
  Files          75       75           
  Lines       15145    15161   +16     
=======================================
+ Hits        14610    14626   +16     
  Misses        535      535           
Impacted Files Coverage Δ
heat/core/manipulations.py 99.51% <100.00%> (+<0.01%) ⬆️
heat/core/tests/test_manipulations.py 99.40% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bda5f9f...415095e. Read the comment docs.

@ClaudiaComito ClaudiaComito requested a review from mtar June 4, 2020 10:32
@mtar mtar merged commit ca40f93 into master Jun 4, 2020
@mtar mtar deleted the features/35-fliplr branch June 4, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement fliplr()
2 participants