Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug variable name in reshape #578

Merged
merged 4 commits into from
Jun 9, 2020
Merged

bug variable name in reshape #578

merged 4 commits into from
Jun 9, 2020

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jun 2, 2020

Description

In reshape a wrong variable is used at one point.

Issue/s resolved: None

Changes proposed:

  • correction of the array name

Type of change

Bug fix

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar added the good first issue Good for newcomers label Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #578 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files          75       75           
  Lines       15169    15169           
=======================================
  Hits        14634    14634           
  Misses        535      535           
Impacted Files Coverage Δ
heat/core/manipulations.py 99.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed9e58...3442b47. Read the comment docs.

@mtar mtar requested a review from coquelin77 June 3, 2020 10:40
@mtar mtar changed the title bug wrong variable name in reshape bug variable name in reshape Jun 4, 2020
@Markus-Goetz Markus-Goetz merged commit d2bf355 into master Jun 9, 2020
@Markus-Goetz Markus-Goetz deleted the bug/reshape_wrong_var branch June 9, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants