-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/490 gnb testing #519
Merged
Merged
Bug/490 gnb testing #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the latter cannot handle the eventuality of empty tensor on a process
ClaudiaComito
added
bug
Something isn't working
testing
Implementation of tests, or test-related issues
labels
Apr 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #519 +/- ##
==========================================
+ Coverage 96.57% 96.59% +0.01%
==========================================
Files 68 68
Lines 14084 14089 +5
==========================================
+ Hits 13602 13609 +7
+ Misses 482 480 -2
Continue to review full report at Codecov.
|
4 tasks
coquelin77
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes assorted bugs that led test_gaussiannb to fail on 7 nodes. The problems were related to how heat functions/methods deal with locally empty tensors.
Issue/s resolved: #490
Changes proposed:
Type of change
Remove irrelevant options:
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no