Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/490 gnb testing #519

Merged
merged 8 commits into from
Apr 2, 2020
Merged

Bug/490 gnb testing #519

merged 8 commits into from
Apr 2, 2020

Conversation

ClaudiaComito
Copy link
Contributor

@ClaudiaComito ClaudiaComito commented Apr 1, 2020

Description

This PR fixes assorted bugs that led test_gaussiannb to fail on 7 nodes. The problems were related to how heat functions/methods deal with locally empty tensors.

Issue/s resolved: #490

Changes proposed:

  • ht.nonzero() now returns dndarray.DNDarray() instead of factories.array(), as the latter gets stuck when one of the nodes has no data (see bug distributed array from scalar #492 - which is NOT solved)
  • dndarray.getitem in distributed mode now returns the correct result both with 0-dim input (a scalar), and with an empty tensor as input.

Type of change

Remove irrelevant options:

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@ClaudiaComito ClaudiaComito added bug Something isn't working testing Implementation of tests, or test-related issues labels Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #519 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   96.57%   96.59%   +0.01%     
==========================================
  Files          68       68              
  Lines       14084    14089       +5     
==========================================
+ Hits        13602    13609       +7     
+ Misses        482      480       -2     
Impacted Files Coverage Δ
heat/core/dndarray.py 96.79% <100.00%> (+0.03%) ⬆️
heat/core/indexing.py 100.00% <100.00%> (ø)
heat/naive_bayes/tests/test_gaussiannb.py 96.03% <100.00%> (-0.07%) ⬇️
heat/core/statistics.py 97.82% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48432ed...ce264e9. Read the comment docs.

@ClaudiaComito ClaudiaComito mentioned this pull request Apr 1, 2020
4 tasks
@coquelin77 coquelin77 merged commit b533215 into master Apr 2, 2020
@coquelin77 coquelin77 deleted the bug/490-gnb-testing branch April 2, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Implementation of tests, or test-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_gaussiannb fails when distributed on 7 processes
2 participants