Implement sort() #312
Merged
Implement sort() #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # heat/core/manipulation.py # heat/core/tests/test_manipulations.py
…ning are not tested much yet
# Conflicts: # heat/core/manipulations.py # heat/core/tests/test_manipulations.py
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 96.99% 97.06% +0.06%
==========================================
Files 53 53
Lines 9051 9265 +214
==========================================
+ Hits 8779 8993 +214
Misses 272 272
Continue to review full report at Codecov.
|
Markus-Goetz
reviewed
Jul 1, 2019
added 2 commits
July 3, 2019 19:55
|
The code is now made more efficient to use less MPI=calls. It still needs one call for each coordinate that is not along the split axis but I don't see a way to improve this because every coordinate needs to be balanced for itself. The speed-up is roughly at about 6 for a vector of size (1000, 1) compared to the version where a MPI-call was made for every swap. |
Markus-Goetz
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets issue #144.
Sort is implemented using some parallel sorting algorithms with pivots and a balancing afterwards. Problem case is where axis = a.split because there the sorting is affected by the values of the other processes. In the end the returned tensor has the same shape as the local input tensor. The lower processes have the lower (higher) values, if sorting is performed ascending (descending) (MPI_WORLD.rank == 0 has the lowest (highest)).
The sorting is not stable, which means that equal elements might be in a different ordering than in the original array. This leads to the problem that the indices of the elements in the original data can be different and still produce the same sorting result.