Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ht.array constructor respects implicit torch device when copy is set to false #1363

Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b1203e7
fix: ht.array constructor respects implicit torch devices
JuanPedroGHM Feb 10, 2024
f1b568b
fix: double splitting on the factories.array method
JuanPedroGHM Feb 26, 2024
5525bb6
fix: added extra tests to cover found cases
JuanPedroGHM Feb 26, 2024
447083e
Merge branch 'main' into bugs/1321-_Bug_factories_array_illegal_param…
JuanPedroGHM Feb 28, 2024
b1ef6f9
Corrected typos, improved error messages, clearer treatment of `copy`…
JuanPedroGHM Mar 4, 2024
3a97d5f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 4, 2024
afb7491
Merge branch 'main' into bugs/1321-_Bug_factories_array_illegal_param…
JuanPedroGHM Mar 4, 2024
6f878fa
wip: check if memory gets reused
JuanPedroGHM Mar 4, 2024
c505200
fix: replaced clone to contiguous
JuanPedroGHM Mar 14, 2024
fdb50f2
Merge branch 'main' into bugs/1321-_Bug_factories_array_illegal_param…
JuanPedroGHM Mar 25, 2024
1e14d7d
Merge branch 'main' into bugs/1321-_Bug_factories_array_illegal_param…
JuanPedroGHM Apr 2, 2024
820bf43
Merge branch 'main' into bugs/1321-_Bug_factories_array_illegal_param…
JuanPedroGHM Apr 8, 2024
91b7125
Merge branch 'main' into bugs/1321-_Bug_factories_array_illegal_param…
JuanPedroGHM Apr 15, 2024
95272ad
Merge branch 'main' into bugs/1321-_Bug_factories_array_illegal_param…
ClaudiaComito Apr 16, 2024
dffa4fa
fix: tutorial, missing target_map variable
JuanPedroGHM Apr 16, 2024
a84ba76
docs: copy example in tutorials
JuanPedroGHM Apr 16, 2024
1c08661
Merge branch 'main' into bugs/1321-_Bug_factories_array_illegal_param…
JuanPedroGHM Apr 17, 2024
7fcf288
Merge branch 'main' into bugs/1321-_Bug_factories_array_illegal_param…
ClaudiaComito Apr 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: replaced clone to contiguous
  • Loading branch information
JuanPedroGHM committed Mar 14, 2024
commit c5052008fc70093c6cd98282ade4da3052c092d2
2 changes: 1 addition & 1 deletion heat/core/factories.py
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ def array(
elif split is not None:
# only keep local slice
_, _, slices = comm.chunk(gshape, split)
_ = obj[slices].clone()
_ = obj[slices].contiguous()
del obj

obj = sanitize_memory_layout(_, order=order)
Expand Down