Merge latest bug fixes from release/1.3.x into main
#1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The copy of tzdata was originally intended to be used from the root of the repository. The documentation states building docker images from the docker directory. This had to be aligned. Moreover, each RUN line in a Dockerfile represents the building of another intermediate image. This has to be taken into account when writing the files. Commands such as "cd" will not work on separate lines.
* upgrade checkout action & use default token * increase tolerance for single-prec torch.inv comparison * fix typo --------- Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>
Docker release 1.3.x update
…-hiccup Increase tolerance for `ht.allclose` on `ht.inv` operations for all torch versions
…e-commit-config Sync `pre-commit` configuration with `main` branch
…o_does_not_work_on_GPU Bug-fix for lasso on GPU
* update version to 1.3.1 before release * revert * update version before release
…nto release/1.3.x
* Update pytorch-latest-release.yml * Update latest-pytorch-support.yml * Delete .github/workflows/pytorch-latest-main.yml * Update checkout version --------- Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>
…nto release/1.3.x
|
Thank you for the PR! |
mtar
previously approved these changes
Dec 22, 2023
|
Thank you for the PR! |
mtar
previously approved these changes
Dec 22, 2023
mtar
previously approved these changes
Dec 22, 2023
|
Thank you for the PR! |
mtar
previously approved these changes
Dec 22, 2023
|
Thank you for the PR! |
|
Thank you for the PR! |
5 tasks
|
OK @mtar I've expanded the tests as much as I could. What's still uncovered is either actually covered by the output shape checks (comparison with numpy outputs), or it is only checked with pytorch < 1.11. I can't do much else here. Thanks and happy holidays! |
mtar
reviewed
Jan 3, 2024
|
Thank you for the PR! |
mtar
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
mainfor new features, latest release branch (e.g.release/1.3.x) for bug fixesDescription
Self-explanatory.
Issue/s resolved: #
Changes proposed:
main1.4.0-devType of change
Bug fix (non-breaking change which fixes an issue)
Memory requirements
NA
Performance
NA
Does this change modify the behaviour of other functions? If so, which?
no