Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set factories default to copy=Nonein line with Python array-API #1117

Closed
ClaudiaComito opened this issue Mar 6, 2023 · 0 comments · Fixed by #1119
Closed

Set factories default to copy=Nonein line with Python array-API #1117

ClaudiaComito opened this issue Mar 6, 2023 · 0 comments · Fixed by #1119
Assignees
@ClaudiaComito
Labels
array API factories memory footprint
Milestone
1.3.0

Comments

@ClaudiaComito
Copy link
Contributor

ClaudiaComito commented Mar 6, 2023 •
edited
Loading

heat.array(obj) by default makes a copy of the underlying object, in sync with np.array. Our users deal with massive arrays by definition, so we should consider deviating from NumPy here.

Related
#991

Feature functionality
I propose to switch to the Python array-API asarray default copy=None and only create a copy when strictly necessary.

Let's revise and release this quickly @Markus-Goetz
@ClaudiaComito ClaudiaComito changed the title Set factories default to copy=False Set factories default to copy=Nonein line with Python array-API Mar 6, 2023
@ClaudiaComito ClaudiaComito added this to the v1.2.3 milestone Mar 6, 2023
@ClaudiaComito ClaudiaComito self-assigned this Mar 6, 2023
@ClaudiaComito ClaudiaComito mentioned this issue Mar 15, 2023
Merged
4 tasks
ClaudiaComito added a commit that referenced this issue Mar 29, 2023
@ClaudiaComito
Merge branch 'main' into features/#1117-array-copy-None
c65eecd
ClaudiaComito added a commit that referenced this issue Mar 30, 2023
@ClaudiaComito
Merge branch 'main' into features/#1117-array-copy-None
52e2c48
ClaudiaComito added a commit that referenced this issue Apr 17, 2023
@ClaudiaComito
Merge branch 'main' into features/#1117-array-copy-None
66069b5
ClaudiaComito added a commit that referenced this issue Apr 17, 2023
@ClaudiaComito
Merge branch 'main' into features/#1117-array-copy-None
f5107b8
@ClaudiaComito ClaudiaComito modified the milestones: v1.2.3, 1.3.0 Apr 17, 2023
ClaudiaComito added a commit that referenced this issue Apr 24, 2023
@ClaudiaComito
Merge branch 'main' into features/#1117-array-copy-None
04b9259
ClaudiaComito added a commit that referenced this issue Apr 27, 2023
@ClaudiaComito
Merge branch 'main' into features/#1117-array-copy-None
25a4cb9
ClaudiaComito added a commit that referenced this issue May 22, 2023
@ClaudiaComito
Merge branch 'main' into features/#1117-array-copy-None
ac2bb29
ClaudiaComito added a commit that referenced this issue May 31, 2023
@ClaudiaComito
Merge branch 'main' into features/#1117-array-copy-None
ca868ea
ClaudiaComito added a commit that referenced this issue Jun 6, 2023
@ClaudiaComito
Merge branch 'main' into features/#1117-array-copy-None
e882c56
ClaudiaComito added a commit that referenced this issue Jun 19, 2023
@ClaudiaComito
Merge branch 'features/#1117-array-copy-None' into features/1053-supp…
681086f 
…ort-Apple-silicon-GPUs
ClaudiaComito added a commit that referenced this issue Jun 19, 2023
@ClaudiaComito
Merge branch 'main' into features/#1117-array-copy-None
7b2a267
mrfh92 added a commit that referenced this issue Jun 19, 2023
@mrfh92
Merge pull request #1119 from helmholtz-analytics/features/#1117-arra…
3a840cc 
…y-copy-None

`ht.array()` default to `copy=None` (e.g., only if necessary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ClaudiaComito ClaudiaComito

Labels
array API factories memory footprint
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

ht.array() default to copy=None (e.g., only if necessary) helmholtz-analytics/heat
1 participant
@ClaudiaComito