Move "simple" middleware functions inline

helmetjs · Jul 28, 2020 · e657b0b · e657b0b
1 parent dda8ab5
commit e657b0b
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 30 deletions.
diff --git a/middlewares/x-download-options/index.ts b/middlewares/x-download-options/index.ts
@@ -1,16 +1,14 @@
 import { IncomingMessage, ServerResponse } from "http";
 
-function xDownloadOptionsMiddleware(
-  _req: IncomingMessage,
-  res: ServerResponse,
-  next: () => void
-): void {
-  res.setHeader("X-Download-Options", "noopen");
-  next();
-}
-
 function xDownloadOptions() {
-  return xDownloadOptionsMiddleware;
+  return function xDownloadOptionsMiddleware(
+    _req: IncomingMessage,
+    res: ServerResponse,
+    next: () => void
+  ): void {
+    res.setHeader("X-Download-Options", "noopen");
+    next();
+  };
 }
 
 module.exports = xDownloadOptions;

diff --git a/middlewares/x-powered-by/index.ts b/middlewares/x-powered-by/index.ts
@@ -1,16 +1,14 @@
 import { IncomingMessage, ServerResponse } from "http";
 
-function xPoweredByMiddleware(
-  _req: IncomingMessage,
-  res: ServerResponse,
-  next: () => void
-) {
-  res.removeHeader("X-Powered-By");
-  next();
-}
-
 function xPoweredBy() {
-  return xPoweredByMiddleware;
+  return function xPoweredByMiddleware(
+    _req: IncomingMessage,
+    res: ServerResponse,
+    next: () => void
+  ) {
+    res.removeHeader("X-Powered-By");
+    next();
+  };
 }
 
 module.exports = xPoweredBy;

diff --git a/middlewares/x-xss-protection/index.ts b/middlewares/x-xss-protection/index.ts
@@ -1,16 +1,14 @@
 import { IncomingMessage, ServerResponse } from "http";
 
-function xXssProtectionMiddleware(
-  _req: IncomingMessage,
-  res: ServerResponse,
-  next: () => void
-) {
-  res.setHeader("X-XSS-Protection", "0");
-  next();
-}
-
 function xXssProtection() {
-  return xXssProtectionMiddleware;
+  return function xXssProtectionMiddleware(
+    _req: IncomingMessage,
+    res: ServerResponse,
+    next: () => void
+  ) {
+    res.setHeader("X-XSS-Protection", "0");
+    next();
+  };
 }
 
 module.exports = xXssProtection;