-
Notifications
You must be signed in to change notification settings - Fork 220
Conversation
src/api/data/cache/cache.go
Outdated
log.WithFields(log.Fields{ | ||
"repo": repo, | ||
"error": err, | ||
}).Error("Error on refresh charts from repo") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the error message should start with a lowercase: "error on refresh..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This is great, thanks @FengyunPan2. Can you update the tests as these are failing because they were expecting the error:
|
Currently if config file have a bad repo and some right repos, monocualr-api don't get charts from repos and no error message to user. We should try all the repos.
661cc34
to
2eada73
Compare
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
- Coverage 83.86% 83.77% -0.09%
==========================================
Files 26 26
Lines 1549 1553 +4
==========================================
+ Hits 1299 1301 +2
- Misses 198 199 +1
- Partials 52 53 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Currently if config file have a bad repo and some right repos,
monocualr-api don't get charts from repos and no error message to
user. We should try all the repos.