Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(helm): add test for 'ParseIntoString' and update test for 'ParseInto' #4188

Merged
merged 1 commit into from
Jun 11, 2018
Merged

test(helm): add test for 'ParseIntoString' and update test for 'ParseInto' #4188

merged 1 commit into from
Jun 11, 2018

Conversation

muehlburger
Copy link

Adding and updating unit tests.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2018
@muehlburger muehlburger changed the title test: add test for 'ParseIntoString' and update test for 'ParseInto' test(helm): add test for 'ParseIntoString' and update test for 'ParseInto' Jun 7, 2018
mattjmcnaughton
mattjmcnaughton approved these changes Jun 7, 2018
View reviewed changes
Copy link

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this test :)

@muehlburger
Copy link
Author

👍

bacongobbler
bacongobbler approved these changes Jun 11, 2018
View reviewed changes
Copy link
Member

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bacongobbler bacongobbler merged commit ee49d24 into helm:master Jun 11, 2018
@muehlburger muehlburger deleted the feat/improve-tests branch June 22, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjmcnaughton mattjmcnaughton mattjmcnaughton approved these changes

@bacongobbler bacongobbler bacongobbler approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muehlburger @bacongobbler @mattjmcnaughton @k8s-ci-robot