-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(semver): Prerelease number comparison issues #2662
Conversation
In prerelease numbers there was the potential for number comparison issues. For example, 99 being greater than 103. This is now fixed.
This does not seem to be fixed on the Helm side I build helm from source as of today and still see the issue. I built semver and tested the comparison and it looks fine on the semver side.
|
Did you make sure to |
ahh that's likely my issue as I assume make would either rebuild the vendor or the vendor was commited. I'll rebuild and verify it's likely just a user error. |
|
Works for me on master. I'd look over your local configuration and try again. Something's messed up on your end.
|
In prerelease numbers there was the potential for number comparison
issues. For example, 99 being greater than 103. This is now fixed.