Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semver): Prerelease number comparison issues #2662

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

mattfarina
Copy link
Collaborator

In prerelease numbers there was the potential for number comparison
issues. For example, 99 being greater than 103. This is now fixed.

In prerelease numbers there was the potential for number comparison
issues. For example, 99 being greater than 103. This is now fixed.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@adamreese adamreese merged commit 2190375 into helm:master Jul 10, 2017
@mattfarina mattfarina deleted the fix/semver-prerelease-num branch July 11, 2017 00:39
@sstarcher
Copy link
Contributor

This does not seem to be fixed on the Helm side

I build helm from source as of today and still see the issue. I built semver and tested the comparison and it looks fine on the semver side.

./bin/helm version
Client: &version.Version{SemVer:"v2.5.0-alpha.1", GitCommit:"1261f71faf1aa8b9a127a6e1759fd799a51d9528", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.4.2", GitCommit:"82d8e9498d96535cc6787a6a9194a76161d29b4c", GitTreeState:"clean"}
./bin/helm search repo/chart -l
NAME                  	VERSION                                           	DESCRIPTION                               
repo/chart	1.0.0-rc.8                                        	descr
repo/chart	1.0.0-rc.7                                        	descr
repo/chart	1.0.0-rc.6                                        	descr
repo/chart	1.0.0-rc.5                                        	descr
repo/chart	1.0.0-rc.4                                        	descr
repo/chart	1.0.0-rc.3                                        	descr
repo/chart	1.0.0-rc.2                                        	descr
repo/chart	1.0.0-rc.11                                       	descr
repo/chart	1.0.0-rc.10                                       	descr
repo/chart	1.0.0-rc.1                                        	descr
 make clean build VERSION=v2.5.0-alpha.1
GOBIN=/Users/shanestarcher/.go/src/github.com/kubernetes/helm/bin go install  -tags '' -ldflags ' -X k8s.io/helm/pkg/version.Version=v2.5.0-alpha.1 -X k8s.io/helm/pkg/version.GitCommit=1261f71faf1aa8b9a127a6e1759fd799a51d9528 -X k8s.io/helm/pkg/version.GitTreeState=clean' k8s.io/helm/cmd/...

@bacongobbler
Copy link
Member

bacongobbler commented Jul 14, 2017

Did you make sure to rm -rf vendor and call make bootstrap again?

@sstarcher
Copy link
Contributor

ahh that's likely my issue as I assume make would either rebuild the vendor or the vendor was commited. I'll rebuild and verify it's likely just a user error.

@sstarcher
Copy link
Contributor

rm -rf vendor && make bootstrap clean build VERSION=v2.5.0-alpha.1
Same results

@bacongobbler
Copy link
Member

bacongobbler commented Jul 14, 2017

Works for me on master. I'd look over your local configuration and try again. Something's messed up on your end.

><> helm-dev version --client
Client: &version.Version{SemVer:"v2.5+unreleased", GitCommit:"1261f71faf1aa8b9a127a6e1759fd799a51d9528", GitTreeState:"clean"}
><> helm-dev search --versions local/test
NAME      	VERSION    	DESCRIPTION                
local/test	0.1.0-rc.10	A Helm chart for Kubernetes
local/test	0.1.0-rc.9 	A Helm chart for Kubernetes
local/test	0.1.0-rc.1 	A Helm chart for Kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants