Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

docs(readme): specify minimum RBAC resources required for migration #210

Merged

Conversation

SohamJ
Copy link
Contributor

@SohamJ SohamJ commented Jul 22, 2022

It might help to list out the resources required instead of multiple
retries to reproduce the issue and docuemnt each one specifically

At the same time ensuring it does not grant additional resources than it needs

Tested against a Tiller setup in Kubernetes v1.16 with Helm 2.8.x -> Helm 3.3.0 migration. I can remove the additional resources note if it is not applicable at all

It might help to list out the resources required instead of multiple
retries to reproduce the issue and docuemnt each one specifically

At the same time ensuring it does not grant additional resources than it needs

Signed-off-by: Soham Jambhekar <soham.jambhekar@adp.com>
@SohamJ SohamJ force-pushed the feature/cluster-rbac-min-resource-requirements branch from a270693 to 1ffb79b Compare July 22, 2022 20:48
@rimusz rimusz self-requested a review July 25, 2022 04:32
@rimusz rimusz self-assigned this Jul 25, 2022
Copy link
Collaborator

@rimusz rimusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rimusz rimusz merged commit 5385f81 into helm:main Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants