Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

feat(cleanup): Cleanup of a release #132

Merged
merged 4 commits into from
Mar 13, 2020
Merged

feat(cleanup): Cleanup of a release #132

merged 4 commits into from
Mar 13, 2020

Conversation

hickeyma
Copy link
Collaborator

Add functionality to cleanup command where user can specify a specific release to remove.

Fixes #122

@hickeyma hickeyma self-assigned this Mar 10, 2020
@hickeyma hickeyma added the enhancement New feature or request label Mar 10, 2020
@hickeyma hickeyma requested a review from rimusz March 10, 2020 17:43
@hickeyma hickeyma mentioned this pull request Mar 10, 2020
Closed
rimusz
rimusz approved these changes Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@rimusz rimusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hickeyma added 2 commits March 11, 2020 09:34
@hickeyma
Add cleanup of a release functionality
d3ff20c 
Fixes #122

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma
Update the release tag
3f8f18e 
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
marckhouzam
marckhouzam reviewed Mar 11, 2020
View reviewed changes
cmd/cleanup.go Outdated Show resolved Hide resolved
@rimusz
Copy link
Collaborator

rimusz commented Mar 12, 2020 •
edited
Loading

also makes sense to add #122 (comment) print the release name to be deleted

@hickeyma
Update after review
5c31cb2 
Review comments:
- #132 (comment)
- #132 (comment)

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma
Copy link
Collaborator Author

also makes sense to add #122 (comment) print the release name to be deleted

Done.

@hickeyma
Copy link
Collaborator Author

hickeyma commented Mar 12, 2020 •
edited
Loading

Thanks @marckhouzam @boarder981 @rimusz for review and comments. Updated and ready for review again.

@hickeyma hickeyma requested review from rimusz and marckhouzam March 12, 2020 12:13
rimusz
rimusz approved these changes Mar 12, 2020
View reviewed changes
Copy link
Collaborator

@rimusz rimusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marckhouzam
marckhouzam approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
That's a great usability improvement!

@marckhouzam
Copy link
Member

Woops, @hickeyma the completion.yaml file should be updated to include the new --name flag.

@hickeyma
Add the flag to completion
3555bfc 
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma
Copy link
Collaborator Author

the completion.yaml file should be updated to include the new --name flag.

Good catch @marckhouzam. Updated and ready for review again.

@hickeyma hickeyma requested a review from marckhouzam March 13, 2020 11:22
marckhouzam
marckhouzam approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hickeyma.
LGTM

@hickeyma hickeyma merged commit 49fcee4 into helm:master Mar 13, 2020
@hickeyma hickeyma deleted the feat/delete-specific-release branch March 13, 2020 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marckhouzam marckhouzam marckhouzam approved these changes

@rimusz rimusz rimusz approved these changes

Assignees

@hickeyma hickeyma

Labels
enhancement New feature or request size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support cleanup targeting one specific release
4 participants
@hickeyma @rimusz @marckhouzam @helm-bot