Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kube2iam] add priorityClassName, upgrade kube2iam #9092

Merged
merged 1 commit into from
Jan 27, 2019
Merged

[stable/kube2iam] add priorityClassName, upgrade kube2iam #9092

merged 1 commit into from
Jan 27, 2019

Conversation

kimxogus
Copy link
Contributor

@kimxogus kimxogus commented Nov 8, 2018

What this PR does / why we need it: Adds priorityClassName and upgrades appVersion

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2018
@kimxogus kimxogus changed the title add priorityClassName, upgrade kube2iam [stable/kube2iam] add priorityClassName, upgrade kube2iam Nov 8, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @kimxogus. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2018
@kimxogus kimxogus force-pushed the stable/kube2iam/priorityClassName branch from ae6d97a to 10f15b8 Compare November 21, 2018 02:23
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2018
@kimxogus
Copy link
Contributor Author

/assign @prydonius

@SharpEdgeMarshall
Copy link
Contributor

any news?

@kimxogus
Copy link
Contributor Author

hope someone review this...

@kimxogus kimxogus force-pushed the stable/kube2iam/priorityClassName branch from 10f15b8 to 7f2432b Compare December 5, 2018 05:32
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2018
@kimxogus kimxogus force-pushed the stable/kube2iam/priorityClassName branch from 7f2432b to 37a5d82 Compare December 7, 2018 08:34
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2018
@kimxogus kimxogus force-pushed the stable/kube2iam/priorityClassName branch from 37a5d82 to 1f75fee Compare December 13, 2018 06:28
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 13, 2018
@kimxogus
Copy link
Contributor Author

/assign @linki

@kimxogus kimxogus force-pushed the stable/kube2iam/priorityClassName branch from 1f75fee to 6953ca5 Compare December 18, 2018 07:29
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2018
@kimxogus
Copy link
Contributor Author

/assign @seanknox

@kimxogus kimxogus force-pushed the stable/kube2iam/priorityClassName branch from 6953ca5 to 5be0d92 Compare December 19, 2018 03:12
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2018
@kimxogus kimxogus force-pushed the stable/kube2iam/priorityClassName branch from 5be0d92 to 9aa4e6b Compare December 24, 2018 16:16
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 24, 2018
@SharpEdgeMarshall
Copy link
Contributor

Could someone please review this?

@kimxogus kimxogus force-pushed the stable/kube2iam/priorityClassName branch from 9aa4e6b to 17ee1a5 Compare January 8, 2019 05:10
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2019
@kimxogus
add priorityClassName, upgrade kube2iam
6d18ee0 
Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
@kimxogus kimxogus force-pushed the stable/kube2iam/priorityClassName branch from 17ee1a5 to 6d18ee0 Compare January 14, 2019 02:12
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2019
@kimxogus
Copy link
Contributor Author

/assign @davidkarlsen

@linki
Copy link
Contributor

linki commented Jan 22, 2019

lgtm

@linki
Copy link
Contributor

linki commented Jan 22, 2019

/unassign @linki

(I'm not a maintainer anymore)

@davidkarlsen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2019
@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, kimxogus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jan 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit edbc986 into helm:master Jan 27, 2019
syedimam0012 pushed a commit to syedimam0012/charts that referenced this pull request Feb 1, 2019
@kimxogus @syedimam0012
add priorityClassName, upgrade kube2iam (helm#9092)
23755d2 
Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
@kimxogus kimxogus deleted the stable/kube2iam/priorityClassName branch March 28, 2019 03:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@linki linki Awaiting requested review from linki

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@davidkarlsen davidkarlsen

@seanknox seanknox

@prydonius prydonius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kimxogus @k8s-ci-robot @SharpEdgeMarshall @linki @davidkarlsen @seanknox @prydonius @helm-bot