This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
nexus/clusterIP-headlessService #8565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
sameersbn
suggested changes
Oct 18, 2018
guptaarvindk
force-pushed
the
nexus/ing-clusterIP
branch
from
ca48cf0 to
46f8eca
Compare
|
hi @sameersbn , I have fixed what you recommended. As anyway we are bumping up the minor rev, I have also added the support for StatefulSet. Please see my comments in this PR. Please feel free to provide feedback. |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/assign |
|
Please merge the latest master branch and fix merge conflicts |
…eadless service. Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com>
guptaarvindk
force-pushed
the
nexus/ing-clusterIP
branch
from
46f8eca to
fd0102c
Compare
helm-bot
added
the
size/L
…y for deploymnet usage. - fixed issues from previous PR - bumped up minor version. Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com>
guptaarvindk
force-pushed
the
nexus/ing-clusterIP
branch
from
fd0102c to
a764fc8
Compare
helm-bot
added
size/L
|
Hi @sameersbn and @rjkernick can you please review the new changes. |
|
Hi @sameersbn and @rjkernick can you please review this PR. Thanks, |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guptaarvindk, rjkernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kenichi-shibata
pushed a commit
to kenichi-shibata/charts
that referenced
this pull request
Oct 30, 2018
* support for clusterIP services with specific cluster IP or None for headless service. Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com> * - added support for statefulsets, while keeping backward compatibility for deploymnet usage. - fixed issues from previous PR - bumped up minor version. Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
* support for clusterIP services with specific cluster IP or None for headless service. Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com> * - added support for statefulsets, while keeping backward compatibility for deploymnet usage. - fixed issues from previous PR - bumped up minor version. Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com> Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
* support for clusterIP services with specific cluster IP or None for headless service. Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com> * - added support for statefulsets, while keeping backward compatibility for deploymnet usage. - fixed issues from previous PR - bumped up minor version. Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for clusterIP services with specific cluster IP or None for headless service.
support for statefulsets (while keeping backward compatibility with development)
Signed-off-by: Arvind Gupta guptaarvindk@gmail.com
What this PR does / why we need it:
if ingress controller is used its better to use headless service behind ingress.
it doesn't make sense to use deployment with static pv/pvc. Every time helm chart is deleted or new deployment created it will use new volume resulting not able to really be persistence across failures/re-starts/re-installs. Better way is to use statefulsets so that volume is truly persistence across failures/re-starts/re-installs. Ideally we dont need Deployment, but for backward compatibility I have kept the deployment as well. User have choice to select one. I have kept deployment as default but StatefulSet should be preferred choice.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]