This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Added support for clusterIP and headless services. #8312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com>
ey-bot
added
the
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
@guptaarvindk thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guptaarvindk, jdolitsky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
faizanahmad055
pushed a commit
to stakater/helm-charts
that referenced
this pull request
Oct 10, 2018
Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com> Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
darioblanco
pushed a commit
to minddocdev/charts
that referenced
this pull request
Oct 22, 2018
Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com>
emas80
pushed a commit
to faceit/charts
that referenced
this pull request
Oct 24, 2018
Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com> Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
Signed-off-by: Arvind Gupta <guptaarvindk@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvind Gupta guptaarvindk@gmail.com
What this PR does / why we need it:
support headless service or specific clusterIp for service.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
support headless service or specific clusterIp for service.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]