Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[CI] Use latest chart-testing image #7203

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

unguiculus
Copy link
Member

Updates CI to use the chart-testing:v1.0.3.

I already pushed the new image (gcr.io/kubernetes-charts-ci/test-image:v2.0.3).

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2018
@unguiculus
Copy link
Member Author

/assign @prydonius

@unguiculus
Copy link
Member Author

cc @helm/charts-maintainers

@unguiculus
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2018
@unguiculus
Copy link
Member Author

I just figured I used jq instead of yq in my change. The Docker image only has yq. I should have tested it with the Docker image too. Will fix it probably tomorrow.

@unguiculus
Copy link
Member Author

Doh, of course, jq is also there since yq is only a wrapper around it. Anyways, I'll do some tests with the Docker image.

@unguiculus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2018
@unguiculus
Copy link
Member Author

OK, test were successful. This can go in.

@mattfarina
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattfarina, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mattfarina,unguiculus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dfc1a33 into helm:master Aug 16, 2018
@unguiculus unguiculus deleted the feature/testing branch August 17, 2018 09:44
marekaf pushed a commit to marekaf/charts that referenced this pull request Sep 4, 2018
Signed-off-by: Marek Bartik <mab@revolgy.com>
Signed-off-by: Marek Bartik <bartimar6@gmail.com>
aba182 pushed a commit to aba182/charts that referenced this pull request Sep 7, 2018
Signed-off-by: aba182 <ajwilhel@gmail.com>
aba182 pushed a commit to aba182/charts that referenced this pull request Sep 7, 2018
Signed-off-by: aba182 <ajwilhel@gmail.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants