Add Prometheus Exports to Mongodb Replicaset #5874

ssalaues · 2018-06-01T22:00:24Z

What this PR does / why we need it:

Adds option for prometheus compatible metric exports in all pods under the Mongodb-replicaset chart
Fixes some broken TLS chart functionality and allows the metrics exporter to use TLS options

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
First PR into kubernetes/charts 😁

1. Moves context of ssl configuration script into /work-dir where certain files are expected to be created. 2. Specifies the --sslMode=requireSSL flag on the container command when using TLS as specified by mongo docs. https://docs.mongodb.com/manual/tutorial/configure-ssl/

k8s-ci-robot · 2018-06-01T22:00:28Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ssalaues · 2018-06-01T22:12:20Z

Just signed the CLA with my github! 😄

Also I added dockerfiles for the container but not necessary to the functionality. If it's not wanted, I can drop those files which would reduce the size of this PR.

ssalaues · 2018-06-01T22:32:59Z

/assign @foxish

prydonius

thanks! lgtm in general, the minor version needs to be bumped as this is a new feature (we follow semver).

/ok-to-test

prydonius · 2018-06-15T18:18:20Z

stable/mongodb-replicaset/Chart.yaml

@@ -1,12 +1,13 @@
 name: mongodb-replicaset
 home: https://github.com/mongodb/mongo
-version: 3.4.0
+version: 3.4.1


this should be bumped to 3.5.0 as this is a new feature

prydonius · 2018-06-15T18:19:53Z

/ok-to-test

ssalaues · 2018-06-15T19:03:23Z

Thanks for the feedback! I bumped the version to 3.5 and fixed the conflicts.

prydonius · 2018-06-18T18:10:14Z

/lgtm

k8s-ci-robot · 2018-06-18T18:10:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prydonius, ssalaues

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~stable/mongodb-replicaset/OWNERS~~ [prydonius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

unguiculus · 2018-06-21T17:40:23Z

@prydonius @ssalaues I'm inclined to revert this PR.

Always adds annotation for Prometheus. You don't need them if you use prometheus-operator.
The Makefile has stuff specific to Google Container Registry in it but the image is on Dockerhub. Why?
Doesn't follow best practices for specifying images.
Most importantly: Uses the admin user for the exporter instead of a user with the clusterMonitor role. This is bad practice and a security risk. We should not have such practices in the chart.

prydonius · 2018-06-21T17:43:48Z

@unguiculus sure, I think we should go ahead and revert this. Once reverted, @ssalaues can re-create a PR to apply the changes and we can try to solve some of the issues you mentioned.

This reverts commit 4fa2cd3.

ssalaues · 2018-06-21T17:55:18Z

@unguiculus I'll make the requested changes and re create the PR. Thanks!

This reverts commit 4fa2cd3.

unguiculus · 2018-06-22T07:00:03Z

@ssalaues Thanks. I'll be happy to assist. You can find my on Kubernetes Slack.

…lm#6253) This reverts commit 4fa2cd3.

* Replicaset Prometheus Metrics export * bugfix: Fix TLS issues 1. Moves context of ssl configuration script into /work-dir where certain files are expected to be created. 2. Specifies the --sslMode=requireSSL flag on the container command when using TLS as specified by mongo docs. https://docs.mongodb.com/manual/tutorial/configure-ssl/ * Documentation on metrics options * Bump Chart Version

…lm#6253) This reverts commit 4fa2cd3.

* Replicaset Prometheus Metrics export * bugfix: Fix TLS issues 1. Moves context of ssl configuration script into /work-dir where certain files are expected to be created. 2. Specifies the --sslMode=requireSSL flag on the container command when using TLS as specified by mongo docs. https://docs.mongodb.com/manual/tutorial/configure-ssl/ * Documentation on metrics options * Bump Chart Version Signed-off-by: voron <av@arilot.com>

…lm#6253) This reverts commit 4fa2cd3. Signed-off-by: voron <av@arilot.com>

Salim Salaues added 3 commits June 1, 2018 14:52

Replicaset Prometheus Metrics export

cd4860c

Documentation on metrics options

3d671c0

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 1, 2018

k8s-ci-robot requested review from foxish and unguiculus June 1, 2018 22:00

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 1, 2018

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 1, 2018

k8s-ci-robot assigned foxish Jun 1, 2018

prydonius reviewed Jun 15, 2018

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 15, 2018

Bump Chart Version

33ea378

ssalaues force-pushed the ft/ZENKO-125 branch from 1c59014 to 33ea378 Compare June 15, 2018 18:59

Merge branch 'master' into ft/ZENKO-125

577e28f

k8s-ci-robot assigned prydonius Jun 18, 2018

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2018

k8s-ci-robot merged commit 4fa2cd3 into helm:master Jun 18, 2018

unguiculus added a commit to unguiculus/charts that referenced this pull request Jun 21, 2018

Revert "Add Prometheus Exports to Mongodb Replicaset (helm#5874)"

b6953e0

This reverts commit 4fa2cd3.

unguiculus mentioned this pull request Jun 21, 2018

Revert "Add Prometheus Exports to Mongodb Replicaset (#5874)" #6253

Merged

k8s-ci-robot pushed a commit that referenced this pull request Jun 21, 2018

Revert "Add Prometheus Exports to Mongodb Replicaset (#5874)" (#6253)

46ba328

This reverts commit 4fa2cd3.

ssalaues mentioned this pull request Jun 22, 2018

[stable/mongodb-replicaset] Prometheus Metrics export #6282

Merged

Ferenc- pushed a commit to Ferenc-/charts that referenced this pull request Jun 26, 2018

Revert "Add Prometheus Exports to Mongodb Replicaset (helm#5874)" (he…

edc6868

…lm#6253) This reverts commit 4fa2cd3.

or1can pushed a commit to or1can/charts that referenced this pull request Jul 10, 2018

Revert "Add Prometheus Exports to Mongodb Replicaset (helm#5874)" (he…

f517633

…lm#6253) This reverts commit 4fa2cd3.

voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018

Revert "Add Prometheus Exports to Mongodb Replicaset (helm#5874)" (he…

7ec7cac

…lm#6253) This reverts commit 4fa2cd3. Signed-off-by: voron <av@arilot.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Prometheus Exports to Mongodb Replicaset #5874

Add Prometheus Exports to Mongodb Replicaset #5874

ssalaues commented Jun 1, 2018

k8s-ci-robot commented Jun 1, 2018

ssalaues commented Jun 1, 2018 •

edited

Loading

ssalaues commented Jun 1, 2018

prydonius left a comment

prydonius Jun 15, 2018

prydonius commented Jun 15, 2018

ssalaues commented Jun 15, 2018

prydonius commented Jun 18, 2018

k8s-ci-robot commented Jun 18, 2018

unguiculus commented Jun 21, 2018 •

edited

Loading

prydonius commented Jun 21, 2018

ssalaues commented Jun 21, 2018

unguiculus commented Jun 22, 2018

Add Prometheus Exports to Mongodb Replicaset #5874

Add Prometheus Exports to Mongodb Replicaset #5874

Conversation

ssalaues commented Jun 1, 2018

k8s-ci-robot commented Jun 1, 2018

ssalaues commented Jun 1, 2018 • edited Loading

ssalaues commented Jun 1, 2018

prydonius left a comment

Choose a reason for hiding this comment

prydonius Jun 15, 2018

Choose a reason for hiding this comment

prydonius commented Jun 15, 2018

ssalaues commented Jun 15, 2018

prydonius commented Jun 18, 2018

k8s-ci-robot commented Jun 18, 2018

unguiculus commented Jun 21, 2018 • edited Loading

prydonius commented Jun 21, 2018

ssalaues commented Jun 21, 2018

unguiculus commented Jun 22, 2018

ssalaues commented Jun 1, 2018 •

edited

Loading

unguiculus commented Jun 21, 2018 •

edited

Loading