Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

fix magic namespace readme #5086

Merged
merged 1 commit into from
Apr 18, 2018
Merged

fix magic namespace readme #5086

merged 1 commit into from
Apr 18, 2018

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Apr 17, 2018

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2018
@k8s-ci-robot k8s-ci-robot requested a review from krancour April 17, 2018 16:02
@krancour
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 18, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, krancour, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit 7f18c65 into helm:master Apr 18, 2018
@cheyang cheyang deleted the fix-magic-namespace branch April 18, 2018 23:00
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants