Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

de-capitalize all the variables of tensorflow-inception #4526

Merged
merged 1 commit into from
Mar 30, 2018
Merged

de-capitalize all the variables of tensorflow-inception #4526

merged 1 commit into from
Mar 30, 2018

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Mar 30, 2018

What this PR does / why we need it:

de-capitalize all the variables, as variables in Charts should not be capitalized.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 30, 2018
@cheyang
Copy link
Collaborator Author

cheyang commented Mar 30, 2018

@timstoop , as your suggestions. PTAL.

@timstoop
Copy link
Contributor

Thanks for this!
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2018
@unguiculus
Copy link
Member

Please bump the minor version for this.

@unguiculus
Copy link
Member

/assign

@cheyang
Copy link
Collaborator Author

cheyang commented Mar 30, 2018

Please bump the minor version for this.

@unguiculus ,
I don't quite understand your meaning. Can you explain by providing example. Thanks very much.

@timstoop
Copy link
Contributor

In Chart.yaml, you bumped the version from 0.2.3 to 0.2.4. That's a bump in patch level. The second number is the minor version. So @unguiculus is requesting you to change the version to 0.3.0 instead.

You may want to look into https://semver.org/ for more info.

@cheyang
Copy link
Collaborator Author

cheyang commented Mar 30, 2018

@timstoop , thanks. You make my day.

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2018
@cheyang
Copy link
Collaborator Author

cheyang commented Mar 30, 2018

@unguiculus, updated as your suggestions. PTAL.

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, timstoop, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2155790 into helm:master Mar 30, 2018
@cheyang cheyang deleted the features/de-capitalize-tf-inception branch March 30, 2018 16:11
rolanddb pushed a commit to Eneco/charts that referenced this pull request Apr 9, 2018
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
bump version to 0.3.0

Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants