Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Update jaeger README to use correct parameters #4445

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

topher200
Copy link
Contributor

This fixes two separate documentation bugs:

  1. When using the elasticsearch storage backend, storage.type=elasticsearch must be set. The given example didn't include this param.
  2. The param names for the query service didn't match the ones in the code.

This fixes two separate doc bugs:
1. When using the elasticsearch storage backend,
   `storage.type=elasticsearch` must be set. The given example
   didn't include this param.
2. The param names for the query service didn't match the ones in the code.
@k8s-ci-robot
Copy link
Contributor

Hi @topher200. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 24, 2018
@topher200
Copy link
Contributor Author

/assign @sameersbn

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 24, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2018
@timstoop
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2018
@unguiculus
Copy link
Member

/lgtm

@unguiculus
Copy link
Member

/assign

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timstoop, topher200, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2018
@unguiculus unguiculus removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit 429e0b2 into helm:master Mar 27, 2018
@topher200 topher200 deleted the patch-1 branch April 5, 2018 16:35
rolanddb pushed a commit to Eneco/charts that referenced this pull request Apr 9, 2018
* Update jaeger README to use correct parameters

This fixes two separate doc bugs:
1. When using the elasticsearch storage backend,
   `storage.type=elasticsearch` must be set. The given example
   didn't include this param.
2. The param names for the query service didn't match the ones in the code.

* version bump
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
* Update jaeger README to use correct parameters

This fixes two separate doc bugs:
1. When using the elasticsearch storage backend,
   `storage.type=elasticsearch` must be set. The given example
   didn't include this param.
2. The param names for the query service didn't match the ones in the code.

* version bump
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
* Update jaeger README to use correct parameters

This fixes two separate doc bugs:
1. When using the elasticsearch storage backend,
   `storage.type=elasticsearch` must be set. The given example
   didn't include this param.
2. The param names for the query service didn't match the ones in the code.

* version bump

Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants