-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Update jaeger README to use correct parameters #4445
Conversation
This fixes two separate doc bugs: 1. When using the elasticsearch storage backend, `storage.type=elasticsearch` must be set. The given example didn't include this param. 2. The param names for the query service didn't match the ones in the code.
Hi @topher200. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @sameersbn |
/lgtm |
/lgtm |
/assign |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timstoop, topher200, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update jaeger README to use correct parameters This fixes two separate doc bugs: 1. When using the elasticsearch storage backend, `storage.type=elasticsearch` must be set. The given example didn't include this param. 2. The param names for the query service didn't match the ones in the code. * version bump
* Update jaeger README to use correct parameters This fixes two separate doc bugs: 1. When using the elasticsearch storage backend, `storage.type=elasticsearch` must be set. The given example didn't include this param. 2. The param names for the query service didn't match the ones in the code. * version bump
* Update jaeger README to use correct parameters This fixes two separate doc bugs: 1. When using the elasticsearch storage backend, `storage.type=elasticsearch` must be set. The given example didn't include this param. 2. The param names for the query service didn't match the ones in the code. * version bump Signed-off-by: voron <av@arilot.com>
This fixes two separate documentation bugs:
storage.type=elasticsearch
must be set. The given example didn't include this param.