Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

ommand-->command #4432

Merged
merged 2 commits into from
Mar 29, 2018
Merged

ommand-->command #4432

merged 2 commits into from
Mar 29, 2018

Conversation

yjl-lgx
Copy link
Contributor

@yjl-lgx yjl-lgx commented Mar 23, 2018

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2018
@yjl-lgx
Copy link
Contributor Author

yjl-lgx commented Mar 23, 2018

/assign @foxish

@yjl-lgx yjl-lgx changed the title ommand-->aommand ommand-->command Mar 24, 2018
Copy link
Collaborator

@carrodher carrodher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should increment chart version (version) in Chart.yaml

version: 0.6.2
@yjl-lgx
Copy link
Contributor Author

yjl-lgx commented Mar 28, 2018

@foxish OK

@timstoop
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 28, 2018
@timstoop
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timstoop, unguiculus, yjl-lgx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit f2cd4c6 into helm:master Mar 29, 2018
rolanddb pushed a commit to Eneco/charts that referenced this pull request Apr 9, 2018
* ommand-->aommand

* version: 0.6.2

version: 0.6.2
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
* ommand-->aommand

* version: 0.6.2

version: 0.6.2
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
* ommand-->aommand

* version: 0.6.2

version: 0.6.2
Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants