Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Update pull request template #4087

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

unguiculus
Copy link
Member

@unguiculus unguiculus commented Mar 9, 2018

  • Wrap general directions into an HTML comment so they are
    not visible in the PR if the user doesn't delete them
  • Add template for information a user is supposed to provide
    in order to avoid getting empty descriptions
  • Add note on CircleCI

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2018
@unguiculus
Copy link
Member Author

cc @kubernetes/charts-maintainers

* Wrap general directions into an HTML comment so they are
  not visible in the PR if the user doesn't delete them
* Add template for information a user is supposed to provide
  in order to avoid getting empty descriptions
* Add note on CircleCI
Copy link
Member

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prydonius, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [prydonius,unguiculus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f4d748d into helm:master Mar 12, 2018
rustycl0ck pushed a commit to rustycl0ck/kubernetes-charts that referenced this pull request Mar 12, 2018
* Wrap general directions into an HTML comment so they are
  not visible in the PR if the user doesn't delete them
* Add template for information a user is supposed to provide
  in order to avoid getting empty descriptions
* Add note on CircleCI
@unguiculus unguiculus deleted the feature/pr-template branch April 3, 2018 17:39
rolanddb pushed a commit to Eneco/charts that referenced this pull request Apr 9, 2018
* Wrap general directions into an HTML comment so they are
  not visible in the PR if the user doesn't delete them
* Add template for information a user is supposed to provide
  in order to avoid getting empty descriptions
* Add note on CircleCI
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
* Wrap general directions into an HTML comment so they are
  not visible in the PR if the user doesn't delete them
* Add template for information a user is supposed to provide
  in order to avoid getting empty descriptions
* Add note on CircleCI
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
* Wrap general directions into an HTML comment so they are
  not visible in the PR if the user doesn't delete them
* Add template for information a user is supposed to provide
  in order to avoid getting empty descriptions
* Add note on CircleCI

Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants