This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Mar 9, 2018
cc @kubernetes/charts-maintainers |
mattfarina
approved these changes
Mar 9, 2018
* Wrap general directions into an HTML comment so they are not visible in the PR if the user doesn't delete them * Add template for information a user is supposed to provide in order to avoid getting empty descriptions * Add note on CircleCI
unguiculus
force-pushed
the
feature/pr-template
branch
from
March 10, 2018 07:24
cfc94fb
to
b25522a
Compare
prydonius
approved these changes
Mar 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prydonius, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rustycl0ck
pushed a commit
to rustycl0ck/kubernetes-charts
that referenced
this pull request
Mar 12, 2018
* Wrap general directions into an HTML comment so they are not visible in the PR if the user doesn't delete them * Add template for information a user is supposed to provide in order to avoid getting empty descriptions * Add note on CircleCI
rolanddb
pushed a commit
to Eneco/charts
that referenced
this pull request
Apr 9, 2018
* Wrap general directions into an HTML comment so they are not visible in the PR if the user doesn't delete them * Add template for information a user is supposed to provide in order to avoid getting empty descriptions * Add note on CircleCI
ichtar
pushed a commit
to Bestmile/charts
that referenced
this pull request
May 15, 2018
* Wrap general directions into an HTML comment so they are not visible in the PR if the user doesn't delete them * Add template for information a user is supposed to provide in order to avoid getting empty descriptions * Add note on CircleCI
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
* Wrap general directions into an HTML comment so they are not visible in the PR if the user doesn't delete them * Add template for information a user is supposed to provide in order to avoid getting empty descriptions * Add note on CircleCI Signed-off-by: voron <av@arilot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
Indicates that a PR is ready to be merged.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not visible in the PR if the user doesn't delete them
in order to avoid getting empty descriptions