Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/wordpress] removes unused externalDatabase.rootPassword param #3940

Merged
merged 3 commits into from
Mar 2, 2018

Conversation

sameersbn
Copy link
Contributor


@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2018
@sameersbn sameersbn assigned sameersbn and unassigned sameersbn Mar 1, 2018
@sameersbn
Copy link
Contributor Author

/assign @tompizmor

@k8s-ci-robot
Copy link
Contributor

@bitnami-bot: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tompizmor
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sameersbn, tompizmor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a51712 into helm:master Mar 2, 2018
@sameersbn sameersbn deleted the wordpress-external-noroot branch March 2, 2018 08:59
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
…am (helm#3940)

* [stable/wordpress] removes unused `externalDatabase.rootPassword` param

* [stable/wordpress] set default value of `externalDatabase.password` to empty string

avoid template rendering errors when no password is required

* [stable/wordpress] bump chart version to 0.8.8
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
…am (helm#3940)

* [stable/wordpress] removes unused `externalDatabase.rootPassword` param

* [stable/wordpress] set default value of `externalDatabase.password` to empty string

avoid template rendering errors when no password is required

* [stable/wordpress] bump chart version to 0.8.8

Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants