Make it possible to add tolerations to fluentd-cw #3931
Conversation
This adds the possability to add tolerations to the fluentd-cloudwatch chart. This is handy if you also want to ship the logs from your master nodes.
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
cncf-cla: no
|
Verify myself |
k8s-ci-robot
added
cncf-cla: yes
|
/assign @sameersbn |
| @@ -20,6 +20,12 @@ resources: | |||
|
|
|||
| # hostNetwork: false | |||
|
|
|||
| ## Add tolerations if specified | |||
| # tolerations: | |||
There was a problem hiding this comment.
Add an empty list as default:
tolerations: []
| @@ -61,6 +61,7 @@ The following tables lists the configurable parameters of the Fluentd Cloudwatch | |||
| | `logGroupName` | AWS Cloudwatch log group | `kubernetes` | | |||
| | `rbac.create` | If true, create & use RBAC resources | `false` | | |||
| | `rbac.serviceAccountName` | existing ServiceAccount to use (ignored if rbac.create=true) | `default` | | |||
| | `tolerations` | Add tolerations | `nil` | | |||
|
@unguiculus I changed it to an empty list. |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/assign |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MattiasGees, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
* Make it possible to add tolerations to fluentd-cw This adds the possability to add tolerations to the fluentd-cloudwatch chart. This is handy if you also want to ship the logs from your master nodes. * Change to empty list
* Make it possible to add tolerations to fluentd-cw This adds the possability to add tolerations to the fluentd-cloudwatch chart. This is handy if you also want to ship the logs from your master nodes. * Change to empty list
* Make it possible to add tolerations to fluentd-cw This adds the possability to add tolerations to the fluentd-cloudwatch chart. This is handy if you also want to ship the logs from your master nodes. * Change to empty list Signed-off-by: voron <av@arilot.com>
This adds the possability to add tolerations to the fluentd-cloudwatch chart. This is handy if you also want to ship the logs from your master nodes.
This is mostly a copy from fluentd-elasticsearch that has the same behaviour.