This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
prometheus service annotations for elastisearch-exporter #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
needs-ok-to-test
|
/assign @sameersbn New to this repo, let me know what I can do to allow this to be merged, or whatever changes would be preferable. |
unguiculus
suggested changes
Feb 23, 2018
| @@ -7,6 +7,10 @@ metadata: | |||
| app: {{ template "elasticsearch-exporter.name" . }} | |||
| release: "{{ .Release.Name }}" | |||
| heritage: "{{ .Release.Service }}" | |||
| annotations: | |||
There was a problem hiding this comment.
I'd suggest you rather make annotations configurable in general. If you use the prometheus-operator you don't need them.
There was a problem hiding this comment.
updated, copied a pattern found in other charts.
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Stelminator, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ichtar
pushed a commit
to Bestmile/charts
that referenced
this pull request
May 15, 2018
* prometheus service annotations for elastisearch-exporter * more canonical service annotation definition
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
* prometheus service annotations for elastisearch-exporter * more canonical service annotation definition Signed-off-by: voron <av@arilot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds annotations so that Prometheus running within Kubernetes will pick up the exposed metrics.