Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Spinnaker Chart #377

Merged
merged 22 commits into from
Jan 20, 2017
Merged

Spinnaker Chart #377

merged 22 commits into from
Jan 20, 2017

Conversation

viglesiasce
Copy link
Contributor

This installs Spinnaker and its dependencies as well as configures Spinnaker to operate as a deployment engine for the local Kubernetes cluster. It also configures 2 Jenkins jobs for use in the implementation of CI pipelines:

  1. build-image: Build and push a Docker image
  2. run-script: Clone a repository and then run a command

For more info about Spinnaker on Kubernetes, check out:
http://www.spinnaker.io/docs/kubernetes-source-to-prod

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2017
@viglesiasce
Copy link
Contributor Author

@k8s-bot e2e test this

@viglesiasce
Copy link
Contributor Author

@technosophos @michelleN here is the chart that I was saying takes a really long time to install and sometimes causes timeouts.

The issue is that it requires multiple job hooks that depend on certain pods to be fully running. The hook jobs do retry and back off but helms' default timeout is not enough for a freshly installed cluster to pull down all of the images and such in time.

Is there a way to make sure Helm does not time out while post install hooks are running or furthermore to ensure that post install hooks have their own timeout?

@lachie83
Copy link
Contributor

@viglesiasce great contrib. I've worked with spinnaker in the past and would like to give the review a shot. It's quite the chart...

@technosophos
Copy link
Member

In 2.2 there is a helm install --timeout=INT flag that can be set on the CLI.

To install the chart with the release name `my-release`:

```bash
$ helm install --name my-release stable/spinnaker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention the timeout value on install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't exist in helm until 2.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note for now. Will update when helm 2.2 ships

1. You will need to create 2 port forwarding tunnels in order to access the Spinnaker UI:
export GATE_POD=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "component=gate,app={{ template "fullname" . }}" -o jsonpath="{.items[0].metadata.name}")
export DECK_POD=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "component=deck,app={{ template "fullname" . }}" -o jsonpath="{.items[0].metadata.name}")
kubectl port-forward $GATE_POD 8084 &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add --namespace {{ .Release.Namespace }} to both port forwards

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done deal.

@lachie83 lachie83 added lgtm Indicates that a PR is ready to be merged. UX reviewed labels Jan 20, 2017
Copy link
Contributor

@lachie83 lachie83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

Jenkins Charts e2e failed for commit d67b6be. Full PR test history. cc @viglesiasce

The magic incantation to run this job again is @k8s-bot e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@viglesiasce viglesiasce merged commit 63685ae into helm:master Jan 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changes needed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants