This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[incubator/kafka] Makes persistence fully configurable #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
needs-ok-to-test
|
/assign @mattfarina |
lsthornt
commented
Feb 14, 2018
incubator/kafka/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v1 | |||
| description: Apache Kafka is publish-subscribe messaging rethought as a distributed | |||
| commit log. | |||
| name: kafka | |||
| version: 0.2.13 | |||
| version: 0.3.0 | |||
There was a problem hiding this comment.
Bumped minor version because some of the top-level config values nested underneath persistence. Otherwise, could be 0.2.14
| @@ -51,24 +51,28 @@ This chart includes a ZooKeeper chart as a dependency to the Kafka | |||
| cluster in its `requirement.yaml` by default. The chart can be customized using the | |||
| following configurable parameters: | |||
|
|
|||
| | Parameter | Description | Default | | |||
There was a problem hiding this comment.
Mostly whitespace changes here, because the #brokerconfigs link got extracted
k8s-ci-robot
added
size/M
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/assign |
k8s-ci-robot
added
size/L
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsthornt, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ichtar
pushed a commit
to Bestmile/charts
that referenced
this pull request
May 15, 2018
* Makes kafka persistentVolume configurable * Downgrades version to 0.3.0 * Cleans up * Fixes indentation * Adds missing spaces for helm lint * Goes back to volumeClaimTemplates to support scaling * Adds missing whitespace eater * Follows best practices for defining storageClassName
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
* Makes kafka persistentVolume configurable * Downgrades version to 0.3.0 * Cleans up * Fixes indentation * Adds missing spaces for helm lint * Goes back to volumeClaimTemplates to support scaling * Adds missing whitespace eater * Follows best practices for defining storageClassName Signed-off-by: voron <av@arilot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimics stable/postgresql and makes persistence fully configurable.
Motivation
We create Kafka StatefulSets during CI on AWS.
Due to the high frequency with which we were creating volumes, EBS wound up getting stuck very frequently.
This change allows us to sidestep the issue by relying on kubelet host volumes.