-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/concourse] Fix typo in Vault cert paths. #3465
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed the CLA. |
Looks fine by me. FYI I have a PR #3254 that makes breaking changes to the keys used for vault configuration, in a wider effort to avoid having your secrets in helm. I don't use Vault, so I'd appreciate an extra set of eyes. I'm in the middle of updating the docs as it's still referencing some old keys, but all the code is stable. |
@william-tran I have reviewed the Vault specific aspects of your PR. Thanks! |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: madmod, unguiculus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
The paths for certs in
/concourse-vault
were using the extensioncrt
instead of the expected extensioncert
which caused the pod to fail with an error.