This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[incubator/jaeger] Allow globally and individual overrides for names of components #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
cc @unguiculus |
|
The fullname template you get with See https://github.com/kubernetes/helm/blob/master/pkg/chartutil/create.go#L265-L281 |
|
Let me do a sanity check on it... it should be good since the defines havent changed. |
|
@unguiculus Ok tested the different combinations and it behaves as expected. |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dvonthenen, unguiculus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Thanks @unguiculus |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a consistent method for a given user to override the default names of components in the Jaeger chart. This is required in order for charts using Jaeger as a dependency to allow the Jaeger components have a consistent naming conventions for the parent charts components. Previously, there was some functionality to do name overrides only for select components, but this PR creates a consistent method for all components in Jaeger.
Currently, the default format all component names are prefixed with --. As an example, if the helm release name is called myrel, the collector deployment is named myrel-jaeger-collector. This PR implements 2 methods of overriding the prefix (-). The first is an option for globally changing the prefix for all components and the second is allowing the individual override of a single component. If both the global override and an individual override of a component is used, the individual component override takes precedence over the global. Please see examples below.
If --set fullnameOverride=mycomponents, the Jaeger components that get deployed will be named:
If --set fullnameOverride=mycomponent and --set query.fullnameOverride=yourcomponents, the Jaeger components that get deployed will be named:
If --set collector.fullnameOverride=thiscomponent and the name of the release is called
myrel, the Jaeger components that get deployed will be named:These nameOverride options are considered very advanced and should only be used by implementers of charts where Jaeger is a dependency chart OR for very advanced users. As such, the README will not be updated to reflect these options.
Tested on kubernetes 1.7 and 1.8 and also tested using Jaeger as a dependent chart to have consistent names with the parent chart.
UPDATE: to reflect the new variable fullnameOverride