Optionally adds liveness and readiness probes to jenkins #3245
Conversation
* Jenkins takes awhile to start the very first time, so we need to wait a bit before the first check
k8s-ci-robot
added
needs-ok-to-test
|
/assign @sameersbn |
|
@jtslear I believe the probes should be enabled by default. Is there any reason for making the heath checks optional? |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
I set it to false by default due to the fact that this was not included in the template from the start. Personally having these checks in place makes sense. But due to not knowing why there weren't included in the first place, I imagine a reason must exist. Let me know and I'll gladly flip the boolean. |
| httpGet: | ||
| path: /login | ||
| port: http | ||
| initialDelaySeconds: {{ .Values.Master.HealthProbesTimeout | default 120 }} |
There was a problem hiding this comment.
please change this to {{ .Values.Master.HealthProbesTimeout }} and add the default value in the values.yaml file
| httpGet: | ||
| path: /login | ||
| port: http | ||
| initialDelaySeconds: {{ .Values.Master.HealthProbesTimeout | default 120 }} |
There was a problem hiding this comment.
please change this to {{ .Values.Master.HealthProbesTimeout }}
stable/jenkins/values.yaml
Outdated
| @@ -34,6 +34,8 @@ Master: | |||
| # HostName: jenkins.cluster.local | |||
| # NodePort: <to set explicitly, choose port between 30000-32767 | |||
| ContainerPort: 8080 | |||
| # Enable Kubernetes Liveness and Readiness Probes | |||
| HealthProbes: false | |||
There was a problem hiding this comment.
please enable the probes by default and update the default value on the readme
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jtslear, sameersbn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
* Optionally adds liveness and readiness probes to jenkins * Jenkins takes awhile to start the very first time, so we need to wait a bit before the first check * Addressing requested changes
/loginas that is what returns an HTTP200 when jenkins is alive