This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/grafana] Make docker image tag fixed (#2480) #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Grafana chart is not immutable because it uses the grafana/grafana:latest image. In my particular case, I need to be able to deploy Grafana one day and know that when I deploy it the next day, I will get the same version. That way I can deploy to many environments over a period of multiple days. This PR locks the image version to the current latest grafana/grafana:4.6.3 Of course, with this change, it becomes essential to make new versions of the chart when a new version of Grafana becomes available. This is the approach taken by many charts.
k8s-ci-robot
added
cncf-cla: yes
|
cc @zanhsieh |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marckhouzam, unguiculus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Grafana chart is not immutable because it uses the
grafana/grafana:latest image.
In my particular case, I need to be able to deploy Grafana one
day and know that when I deploy it the next day, I will get the
same version. That way I can deploy to many environments over a
period of multiple days.
This PR locks the image version to the current latest
grafana/grafana:4.6.3
Of course, with this change, it becomes essential to make new
versions of the chart when a new version of Grafana becomes
available. This is the approach taken by many charts.