Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/traefik] Add ability to enable hostPort setup #3129

Merged
merged 2 commits into from
Jan 4, 2018
Merged

[stable/traefik] Add ability to enable hostPort setup #3129

merged 2 commits into from
Jan 4, 2018

Conversation

aslafy-z
Copy link
Contributor

This will allow us to configure traefik to use hostPort.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2017
@mattfarina
Copy link
Contributor

@aslafy-z Can you try commenting again to catch the CLA. If that doesn't work, please make sure the CLA site is linked to your github account.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 27, 2017
@aslafy-z
Copy link
Contributor Author

CLA done

@krancour
Copy link
Contributor

krancour commented Jan 3, 2018 •
edited
Loading

This seems pretty reasonable. LGTM. Version bump is wrong.

krancour
krancour reviewed Jan 3, 2018
View reviewed changes
stable/traefik/Chart.yaml Outdated
@@ -1,6 +1,6 @@
apiVersion: v1
name: traefik
version: 1.14.5
version: 1.14.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this adds a feature, we should be bumping to 1.15.0.

@mattfarina
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 4, 2018
@mattfarina
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aslafy-z, mattfarina

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0d17ecc into helm:master Jan 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krancour krancour krancour left review comments

Assignees

@mattfarina mattfarina

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aslafy-z @k8s-ci-robot @mattfarina @krancour