Added Pachyderm chart #3114

jonandernovella · 2017-12-20T10:49:22Z

Pachyderm is a language-agnostic and cloud infrastructure-agnostic large-scale data processing framework based on software containers. This chart can be used to deploy Pachyderm locally or backed by object stores of different Cloud providers.

mcapuccini · 2017-12-20T10:50:46Z

+1

mcapuccini · 2017-12-20T10:51:25Z

@jonandernovella I think you are supposed to put this in the incubation directory.

jonandernovella · 2017-12-20T10:56:36Z

@mcapuccini I tried to meet all the guidelines for it to be stable!

jonandernovella · 2017-12-20T12:21:47Z

/assign @prydonius

prydonius

Can I suggest moving etcd out into it's own chart (ideally improving the existing incubator chart and moving it to stable) and bringing it in as a dependency?

prydonius · 2018-01-02T10:20:28Z

stable/pachyderm/README.md

+| Parameter                | Description           | Default           |
+|--------------------------|-----------------------|-------------------|
+| `pachd.image.repository` | Container image name  | `pachyderm/pachd` |
+| `*.image.tag`            | Container image tag   | `1.6.6`           |


you could use something like <latest version> to avoid having to update this README each time the version is bumped

prydonius · 2018-01-02T10:20:47Z

stable/pachyderm/Chart.yaml

+  - distributed
+  - processing
+version: 0.1.0
+home: "https://pachyderm.io"


would it make sense to add this icon? https://avatars2.githubusercontent.com/u/10432478?s=200&v=4

prydonius · 2018-01-02T14:55:08Z

stable/pachyderm/templates/NOTES.txt

+
+To check that installation was successful, you can try running pachctl help, which should return a list of Pachyderm commands. Please note that the client version should correspond to the pachd service version. For more information please consult: http://pachyderm.readthedocs.io/en/latest/index.html. 
+
+If you install the client on your master node, you should already be able to interact with the service. Also, if you have your kubernetes client properly configured to talk with your remote cluster, you can simply install `pachctl` on your local machine and execute: `pachctl port-forward &`.


Can we print out a useable pachctl command? e.g. pachctl port-forward -k -n {{.Release.Namespace}} & would be useful when pachd is not in the default/configured NS.

prydonius · 2018-01-03T13:07:36Z

stable/pachyderm/Chart.yaml

+  - reproducibility
+  - distributed
+  - processing
+version: 0.1.0


appVersion should be set to 1.6.6

prydonius · 2018-01-03T13:08:04Z

stable/pachyderm/templates/NOTES.txt

+
+On Linux environments:
+
+$ curl -o /tmp/pachctl.deb -L https://github.com/pachyderm/pachyderm/releases/download/v1.6.6/pachctl_1.6.6_amd64.deb && sudo dpkg -i /tmp/pachctl.deb


with appVersion set in Chart.yaml, you can template this with {{.Chart.AppVersion}} I think

prydonius

almost there, just a few small fixes and then I think this is good to go!

prydonius · 2018-01-04T09:40:48Z

stable/pachyderm/README.md

+We strongly suggest that the installation of Pachyderm should be performed in its own namespace. The default installation will deploy Pachyderm on your local Kubernetes cluster:
+
+```console
+$ helm install --name my-release stable/pachyderm


Adding --namespace pachyderm would be good to illustrate the above recommendation.

prydonius · 2018-01-04T09:42:29Z

stable/pachyderm/templates/NOTES.txt

+
+To check that installation was successful, you can try running pachctl help, which should return a list of Pachyderm commands.  
+
+If you install the client on your master node, you should already be able to interact with the service. Also, if you have your kubernetes client properly configured to talk with your remote cluster, you can simply install `pachctl` on your local machine and execute: `pachctl -k ‘-n={{ .Release.Namespace }}’ port-forward &`.


are the quote marks supposed to be around ‘-n={{ .Release.Namespace }}’?

I think so. As far as I read it needs to be there

prydonius · 2018-01-04T11:07:47Z

Can I suggest moving etcd out into it's own chart (ideally improving the existing incubator chart and moving it to stable) and bringing it in as a dependency?

@jonandernovella and I discussed this on Slack, unfortunately pachyderm expects a service called etcd and the pachctl client also expects a deployment named pachd to port-forward to. Therefore, this chart doesn't use the convention "fullname" template for naming deployments and services. In the README, we're recommending that the chart be installed in its own namespace.

prydonius · 2018-01-04T12:53:46Z

/lgtm

prydonius · 2018-01-04T12:54:11Z

/ok-to-test

prydonius · 2018-01-04T12:55:37Z

/lgtm cancel

prydonius · 2018-01-04T12:58:54Z

stable/pachyderm/Chart.yaml

+sources:
+  - "https://github.com/pachyderm/pachyderm"
+maintainers:
+  - name: Jon Ander Novella


can you make sure all names are actually GitHub IDs? It makes it easier to reference back. Also, please add an OWNERS file (see format), which will allow anyone listed there to approve PRs.

prydonius

/lgtm

k8s-ci-robot · 2018-01-04T13:10:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonandernovella, prydonius

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [prydonius]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Added Pachyderm chart

35aa103

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 20, 2017

k8s-ci-robot assigned prydonius Dec 20, 2017

prydonius reviewed Jan 2, 2018

View reviewed changes

prydonius reviewed Jan 3, 2018

View reviewed changes

Added appVersion field and updated instructions

6d120b0

prydonius reviewed Jan 4, 2018

View reviewed changes

Added namespace flag to deployment commands

544ca86

k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 4, 2018

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 4, 2018

k8s-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 4, 2018

prydonius reviewed Jan 4, 2018

View reviewed changes

jonandernovella added 2 commits January 4, 2018 14:05

Added OWNERS file

0d2c4d9

Updated OWNERS file and changed names with github ids

f588ff0

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2018

prydonius approved these changes Jan 4, 2018

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2018

k8s-ci-robot merged commit 856f6b5 into helm:master Jan 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Pachyderm chart #3114

Added Pachyderm chart #3114

jonandernovella commented Dec 20, 2017 •

edited

Loading

mcapuccini commented Dec 20, 2017 •

edited

Loading

mcapuccini commented Dec 20, 2017

jonandernovella commented Dec 20, 2017

jonandernovella commented Dec 20, 2017

prydonius left a comment

prydonius Jan 2, 2018

prydonius Jan 2, 2018

prydonius Jan 2, 2018

prydonius Jan 3, 2018

prydonius Jan 3, 2018

prydonius left a comment

prydonius Jan 4, 2018

prydonius Jan 4, 2018

jonandernovella Jan 4, 2018

prydonius commented Jan 4, 2018

prydonius commented Jan 4, 2018

prydonius commented Jan 4, 2018

prydonius commented Jan 4, 2018

prydonius Jan 4, 2018

prydonius left a comment

k8s-ci-robot commented Jan 4, 2018


		To check that installation was successful, you can try running pachctl help, which should return a list of Pachyderm commands. Please note that the client version should correspond to the pachd service version. For more information please consult: http://pachyderm.readthedocs.io/en/latest/index.html.

		If you install the client on your master node, you should already be able to interact with the service. Also, if you have your kubernetes client properly configured to talk with your remote cluster, you can simply install `pachctl` on your local machine and execute: `pachctl port-forward &`.


		On Linux environments:

		$ curl -o /tmp/pachctl.deb -L https://github.com/pachyderm/pachyderm/releases/download/v1.6.6/pachctl_1.6.6_amd64.deb && sudo dpkg -i /tmp/pachctl.deb

Added Pachyderm chart #3114

Added Pachyderm chart #3114

Conversation

jonandernovella commented Dec 20, 2017 • edited Loading

mcapuccini commented Dec 20, 2017 • edited Loading

mcapuccini commented Dec 20, 2017

jonandernovella commented Dec 20, 2017

jonandernovella commented Dec 20, 2017

prydonius left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prydonius left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prydonius commented Jan 4, 2018

prydonius commented Jan 4, 2018

prydonius commented Jan 4, 2018

prydonius commented Jan 4, 2018

Choose a reason for hiding this comment

prydonius left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 4, 2018

jonandernovella commented Dec 20, 2017 •

edited

Loading

mcapuccini commented Dec 20, 2017 •

edited

Loading