Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Adding process to become a chart OWNER/approver to the README.md #3076

Merged
merged 1 commit into from
Dec 18, 2017

Conversation

mattfarina
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2017
Copy link
Member

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@prydonius
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattfarina, prydonius

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [mattfarina,prydonius]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a48153 into helm:master Dec 18, 2017
goruha added a commit to cloudposse-archives/charts-official that referenced this pull request Dec 19, 2017
…/charts-official into charmuseum-cloudposse-version

* 'charmuseum-cloudposse-version' of github.com:cloudposse/charts-official: (50 commits)
  [incubator/kubewatch] add kubewatch chart (helm#2705)
  [stable/rabbitmq-ha] Add RabbitMQ HA chart (helm#3005)
  Handling the case of a new chart in the e2e tests (helm#3083)
  Fix wrong var name in NOTES when Ingress is enabled (helm#3060)
  correct typo in comment (helm#3077)
  [stable/sonatype-nexus]: Do not set targetPort for ClusterIP  (helm#3069)
  Fix NOTES.txt for kafka chart (helm#3064)
  fix typo for template name (helm#3070)
  Update README.md (helm#3035)
  Updated the stale issue/pr handling in the README (helm#3054)
  etcd-operator: namespace is needed in to interact with cluster (helm#3053)
  [stable/mongodb] Release 0.4.21 (helm#3073)
  Better resource management for Artifactory (helm#3021)
  [stable/etcd-operator] changes to account for current v0.7.0  (helm#2826)
  readme typo fix and add --purge to helm delete (helm#3039)
  [stable/concourse] Add rbac to concourse worker (helm#2922)
  Adding process to become a chart OWNER/approver to the README.md (helm#3076)
  Redis-ha fixes (helm#2977)
  Use Values.uuid for cluster id with default of uuidv4 (helm#3055)
  incubator/oauth-proxy Allow path to be configured (helm#2936)
  ...
@mattfarina mattfarina deleted the owners/add-process branch December 19, 2017 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants