Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

stable/mysql: Make liveness and readiness probes configurable #3068

Merged
merged 3 commits into from
Dec 22, 2017
Merged

stable/mysql: Make liveness and readiness probes configurable #3068

merged 3 commits into from
Dec 22, 2017

Conversation

kongslund
Copy link
Contributor

I had a need to configure initialDelaySeconds for the liveness probe. In this PR I've made all the liveness and readiness probe values configurable. The naming convention is similar to Sonarqube.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2017
@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 22, 2017
@unguiculus
Copy link
Member

/retest

@unguiculus
Copy link
Member

/retest

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kongslund, unguiculus

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2017
@k8s-ci-robot k8s-ci-robot merged commit 1b0a9af into helm:master Dec 22, 2017
@kongslund kongslund deleted the mysql-probes branch January 14, 2018 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants