Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Make value nameOverride overide name completely #2773

Merged
merged 7 commits into from
Dec 15, 2017
Merged

Make value nameOverride overide name completely #2773

merged 7 commits into from
Dec 15, 2017

Conversation

pulledtim
Copy link
Contributor

The value "nameOverride" should set the complete name of the deployment/service, not just a part of it.
#2772

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2017
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 17, 2017
unguiculus
unguiculus suggested changes Dec 5, 2017
View reviewed changes
stable/gcloud-sqlproxy/templates/_helpers.tpl Outdated
@@ -11,6 +11,6 @@ Create a default fully qualified app name.
We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
*/}}
{{- define "gcloud-sqlproxy.fullname" -}}
{{- $name := default .Chart.Name .Values.nameOverride -}}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
{{- $name := .Values.nameOverride | default (printf "%s-%s" .Release.Name .Release.Name) -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nameOverride is meant for the name template. Either add a fullnameOverride or do something like this: https://github.com/kubernetes/charts/blob/master/incubator/oauth-proxy/templates/_helpers.tpl#L14-L18

@unguiculus
Copy link
Member

Also marking stale. Please fix your CLA.

@pulledtim
Copy link
Contributor Author

@unguiculus Thank you for your input. I added a new parameter fullnameOverride as you proposed. CLA should have been signed now by employer, will find out why its not shown yet.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 12, 2017
@pulledtim
Copy link
Contributor Author

/assign @unguiculus

@unguiculus unguiculus removed the stale label Dec 13, 2017
@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 15, 2017
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tim-Smyth, unguiculus

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2017
@k8s-ci-robot k8s-ci-robot merged commit c41350a into helm:master Dec 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unguiculus unguiculus unguiculus approved these changes

Assignees

@unguiculus unguiculus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pulledtim @k8s-ci-robot @unguiculus