Add Elastalert chart #2676
Add Elastalert chart #2676
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
We've started namespacing templates. See #1785. Please apply to your PR. |
|
Hi @unguiculus I have added namespacing templates to this PR |
| apiVersion: extensions/v1beta1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: {{ template "fullname" . }} |
stable/elastalert/Chart.yaml
Outdated
| - https://github.com/krizsan/elastalert-docker | ||
| - https://github.com/Yelp/elastalert | ||
| maintainers: | ||
| - name: Peter Grant |
| @@ -0,0 +1,11 @@ | |||
| description: ElastAlert is a simple framework for alerting on anomalies, spikes, or other patterns of interest from data in Elasticsearch. | |||
| name: elastalert | |||
| version: 0.1.0 | |||
stable/elastalert/values.yaml
Outdated
| # docker image | ||
| repository: ivankrizsan/elastalert | ||
| # docker image tag | ||
| tag: latest |
stable/elastalert/values.yaml
Outdated
| repository: ivankrizsan/elastalert | ||
| # docker image tag | ||
| tag: latest | ||
| pullPolicy: Always |
stable/elastalert/README.md
Outdated
| | `image.repository` | docker image | ivankrizsan/elastalert | | ||
| | `image.tag` | docker image tag | latest | | ||
| | `replicaCount` | number of replicas to run | 1 | | ||
| | `pullPolicy | image pull policy | Always | |
| spec: | ||
| containers: | ||
| - name: elastalert | ||
| image: {{ .Values.image.repository }} |
There was a problem hiding this comment.
Tag and pullPolicy are not used.
| template: | ||
| metadata: | ||
| name: {{ template "elastalert.fullname" . }}-elastalert | ||
| labels: |
There was a problem hiding this comment.
Only app and release labels should go here. I don't think we need a component label since there is no multiple components in this chart. All four labels should go below metadata. The configmaps have it correctly.
|
requested changes have been added @unguiculus |
| name: {{ template "elastalert.fullname" . }} | ||
| labels: | ||
| app: {{ template "elastalert.name" . }} | ||
| release: {{ .Release.Name }} |
There was a problem hiding this comment.
release and heritage missing
| @@ -0,0 +1,49 @@ | |||
| {{- $root := . }} | |||
| apiVersion: extensions/v1beta1 | |||
|
@unguiculus apologies, I misunderstood your earlier comment on labels, have fixed up labels and apiversion. |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
| revisionHistoryLimit: {{ .Values.revisionHistoryLimit }} | ||
| template: | ||
| metadata: | ||
| name: {{ template "elastalert.fullname" . }}-elastalert |
There was a problem hiding this comment.
Add app and release labels here.
|
@unguiculus Have tidied up everything requested. Please let me know if there is anything else. |
| @@ -0,0 +1,54 @@ | |||
| {{- $root := . }} | |||
| @@ -0,0 +1,14 @@ | |||
| {{- $root := . }} | |||
|
@unguiculus have removed unused lines |
|
/lgtm |
|
@pickledrick Why did you use port 80 and not 9200 which is the common ElasticSearch port? |
No description provided.