This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Prometheus: add kube-state-metrics #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.
If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
|
k8s-ci-robot
added
the
cncf-cla: yes
|
@mgoodness can you rebase to resolve the conflict in the README? |
As mentioned in #229. From https://github.com/kubernetes/kube-state-metrics: > kube-state-metrics is a simple service that listens to the Kubernetes > API server and generates metrics about the state of the objects. Also increased truncation to 63 characters.
|
You got it. Note that I had a mistake in the README from my other PR. Fixed that while I was in there. |
|
@k8s-bot ok to test |
|
Just tested this and seeing the metrics come right up. Thanks @mgoodness!! |
viglesiasce
added
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #229.
From https://github.com/kubernetes/kube-state-metrics:
Also increased truncation to 63 characters.