-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/coredns] separate creation of prometheus service from operator #22804
[stable/coredns] separate creation of prometheus service from operator #22804
Conversation
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com>
Hi @IronHalo. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironhalo, scottrigby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com> Signed-off-by: camelusluo <camelusluo@tencent.com>
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com>
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com>
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
@acaleph @shashidharatd @andor44 @mrueg
Is this a new chart
No.
What this PR does / why we need it:
Not all metrics platforms require the Prometheus Operator to scrape metrics
Which issue this PR fixes
N/A
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)