Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/coredns] separate creation of prometheus service from operator #22804

Merged
merged 1 commit into from
Jun 15, 2020
Merged

[stable/coredns] separate creation of prometheus service from operator #22804

merged 1 commit into from
Jun 15, 2020

Conversation

pwhitehead00
Copy link
Contributor

@acaleph @shashidharatd @andor44 @mrueg

Is this a new chart

No.

What this PR does / why we need it:

Not all metrics platforms require the Prometheus Operator to scrape metrics

Which issue this PR fixes

N/A

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2020
@k8s-ci-robot k8s-ci-robot requested a review from andor44 June 15, 2020 18:08
@k8s-ci-robot
Copy link
Contributor

Hi @IronHalo. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 15, 2020
@viglesiasce
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2020
@viglesiasce
Copy link
Contributor

/retest

@scottrigby
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironhalo, scottrigby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit cea2d6f into helm:master Jun 15, 2020
camelus0211 pushed a commit to camelus0211/charts that referenced this pull request Jul 6, 2020
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com>
Signed-off-by: camelusluo <camelusluo@tencent.com>
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
Signed-off-by: Paul Whitehead <whitehead.pauljay@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
@pwhitehead00 pwhitehead00 deleted the optional-servicemonitor branch September 30, 2020 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants