Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus] gRPC port on headless svc #22784

Merged
merged 2 commits into from
Jun 16, 2020
Merged

[stable/prometheus] gRPC port on headless svc #22784

merged 2 commits into from
Jun 16, 2020

Conversation

carlosjgp
Copy link
Contributor

Signed-off-by: Carlos Juan Gómez Peñalver carlosjuangp@gmail.com

What this PR does / why we need it:

Add the Thanos gRPC port to the headless service when deploying Prometheus Server using StatefulSet

Which issue this PR fixes

Special notes for your reviewer:

@gianrubio @zanhsieh

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

carlosjgp added 2 commits June 14, 2020 13:28
@carlosjgp
[stable/prometheus] gRPC port on headless svc
ea3d17f 
Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>
@carlosjgp
[stable/prometheus] Add new variables to docs
585c1d2 
Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @carlosjgp. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zanhsieh
Copy link
Collaborator

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2020
@zanhsieh
Copy link
Collaborator

/test pull-charts-e2e

1 similar comment
@zanhsieh
Copy link
Collaborator

/test pull-charts-e2e

@carlosjgp
Copy link
Contributor Author

carlosjgp commented Jun 15, 2020 •
edited
Loading

this error doesn't seem to be related to my PR

...
I0614 20:31:21.922] ------------------------------------------------------------------------------------------------------------------------
I0614 20:31:21.922] ==> Logs of container prometheus-j2ggsksfxv-server-67585ff856-psqwx
I0614 20:31:21.923] ------------------------------------------------------------------------------------------------------------------------
I0614 20:31:22.284] Error from server (BadRequest): container "prometheus-server-configmap-reload" in pod "prometheus-j2ggsksfxv-server-67585ff856-psqwx" is waiting to start: ContainerCreating
I0614 20:31:22.284] Error printing details: Error waiting for process: exit status 1
...

Should e2e test timeouts reconsider?

@carlosjgp
Copy link
Contributor Author

/retest

@zanhsieh
Copy link
Collaborator

/test pull-charts-e2e

@scottrigby
Copy link
Member

Testing infra was fixed, so last failure shouldn't happen again

@scottrigby
Copy link
Member

/retest

@zanhsieh
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlosjgp, zanhsieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 11964fb into helm:master Jun 16, 2020
@carlosjgp carlosjgp deleted the issue_22783 branch June 16, 2020 07:27
camelus0211 pushed a commit to camelus0211/charts that referenced this pull request Jul 6, 2020
@carlosjgp
[stable/prometheus] gRPC port on headless svc (helm#22784)
5ade171 
* [stable/prometheus] gRPC port on headless svc

Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>

* [stable/prometheus] Add new variables to docs

Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>
Signed-off-by: camelusluo <camelusluo@tencent.com>
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@carlosjgp
[stable/prometheus] gRPC port on headless svc (helm#22784)
34e8913 
* [stable/prometheus] gRPC port on headless svc

Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>

* [stable/prometheus] Add new variables to docs

Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@carlosjgp @includerandom
[stable/prometheus] gRPC port on headless svc (helm#22784)
ade2c00 
* [stable/prometheus] gRPC port on headless svc

Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>

* [stable/prometheus] Add new variables to docs

Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@carlosjgp @li-adrienloiseau
[stable/prometheus] gRPC port on headless svc (helm#22784)
701ef9a 
* [stable/prometheus] gRPC port on headless svc

Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>

* [stable/prometheus] Add new variables to docs

Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@carlosjgp
[stable/prometheus] gRPC port on headless svc (helm#22784)
cad16fa 
* [stable/prometheus] gRPC port on headless svc

Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>

* [stable/prometheus] Add new variables to docs

Signed-off-by: Carlos Juan Gómez Peñalver <carlosjuangp@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
@rileyhun rileyhun mentioned this pull request Apr 8, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanhsieh zanhsieh zanhsieh approved these changes

@gianrubio gianrubio Awaiting requested review from gianrubio

Assignees

@zanhsieh zanhsieh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/prometheus] Enable gRPC port for Thanos sidecar on the headless service
5 participants
@carlosjgp @k8s-ci-robot @zanhsieh @scottrigby @helm-bot