[stable/spinnaker] Fix kubeconfig s3 bucket configuration in spinnaker chart

[Karthik-13]

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No

What this PR does / why we need it:

This PR fixes bug in spinnaker helm chart which expects kubeconfig secret as a volume mount even when s3 bucket is chosen as the source.

Which issue this PR fixes

• fixes [stable/spinnaker] Do not expect volume mount for kubeconfig when using encrypted s3 bucket #22765

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/mychartname])

[k8s-ci-robot]

Hi @Karthik-13. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Karthik-13]

/assign @paulczar

[paulczar]

/ok-to-test
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-13, paulczar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/spinnaker/OWNERS [paulczar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[scottrigby]

/retest

[paulczar]

It's not clear to me what the error here was. let's retry in case it was transitive.

/retest

[shubhamc183]

@Karthik-13 looks like the issue is NOT resolved yet. Volume entry is getting created.

When kubeConfig.secretName and kubeConfig.secretKey are commented

kubeConfig:
  enabled: true
  #secretName: kubeconfig
  #secretKey: masterkubeconfig
  encryptedKubeconfig: encrypted:s3!r:us-east-1!b:BUCKET_NAME!f:masterkubeconfig

YAML generated contains

      volumes:
      - name: kube-config
        secret:
          secretName: my-kubeconfig

Not sure where exactly "my-kubeconfig" is coming from.

When kubeConfig.secretName = false
kubeConfig:
enabled: true
secretName: false
#secretKey: masterkubeconfig
encryptedKubeconfig: encrypted:s3!r:us-east-1!b:BUCKET_NAME!f:masterkubeconfig

YAML generated contains

  volumes:
  - name: kube-config
    secret:
      secretName: false

[Karthik-13]

@shubhamc183 Could you please provide more information such as your environment, app version, chart version that you are using currently?

[shubhamc183]

env: K8s, EKS
version: 2.0.0-rc9
appVersion: 1.16.2