-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Conversation
zonorti
commented
Nov 17, 2016
- For more fine-grained control on MongoDB configuration moving mongod.conf to ConfigMap from the container.
- To have the container more lightweight - switching to alpine. Should be enough for running bash scripts.
- ReplicaSet and ClusterRole added as values for easier multi-shard cluster creation. Also added as labels for discovery purpose.
Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.
If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
15c498f
to
2090f55
Compare
CLAs look good, thanks! |
@k8s-bot ok to test |
@viglesiasce I'll take a look at it today and push the image as well. Thanks! |
Merge conflicts need to be fixed? @imelnik |
@foxish @viglesiasce sure, I would update this PR |
8482159
to
6ddba58
Compare
7b27fc6
to
a0ddd09
Compare
a0ddd09
to
a5e1b12
Compare
@k8s-bot e2e test this |
@imelnik: you can't request testing unless you are a kubernetes member. In response to this comment:
If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository. |
@foxish this e2e fail looks like a Jenkins problem |
@k8s-bot e2e test this |
The change LGTM. I'm trying to deploy it once but helm seems to have issues when I have a cluster spun up using Kubernetes release-1.5. |
@viglesiasce This looks like an e2e testing framework issue. Any ideas why it's picking a large garbled namespace to deploy? |
@foxish looks like something has changed on the Jenkins side. The ghprbPullId is now showing as that rather than the PR Id. Will look today. |
Opened kubernetes/test-infra#1253, sorry for the churn folks. |
@k8s-bot e2e test this |
@viglesiasce thanks for checking tests! |
@foxish can you push the image when you get a chance? |
@viglesiasce On it |
Done. |
I still can't test this.
|
I am able to install on a 1.4.x cluster but seeing the following in the
|
I guess it makes sense to wait till 1.5 release and have it updated at that time |
@imelnik I made a couple of changes to your PR, to work with StatefulSets in k8s1.5. I see the same issue as @viglesiasce did with the bootstrap container. PTAL. |
1. The component labels need to match. 2. Changed annotation to alpha from beta
@imelnik @viglesiasce Pushed commit to fix the issue with bootstrap. It works well on my local setup. This is ready for merge once that change is made. |
@k8s-bot e2e test this |
Jenkins Charts e2e failed for commit afd64d2. Full PR test history. The magic incantation to run this job again is |
@viglesiasce We're not testing on a 1.5 cluster yet? I updated the reference to StatefulSet and that seems to be why it's failing. |
Correct. We will move to 1.5 once GKE has it ready. Until then we wont block this (or other SS prs). Once CI is pointing to 1.5 I will send a PR to move this to the stable folder. |
@viglesiasce @foxish thanks for updating and megring this one! |
Update with 2.10.0 related YAMLs. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>