Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Use ConfigMap for mongo configuration #223

Merged
merged 3 commits into from
Dec 19, 2016

Conversation

zonorti
Copy link
Contributor

@zonorti zonorti commented Nov 17, 2016

  • For more fine-grained control on MongoDB configuration moving mongod.conf to ConfigMap from the container.
  • To have the container more lightweight - switching to alpine. Should be enough for running bash scripts.
  • ReplicaSet and ClusterRole added as values for easier multi-shard cluster creation. Also added as labels for discovery purpose.

@k8s-ci-robot
Copy link
Contributor

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@zonorti zonorti force-pushed the mongo-configset-configuration branch from 15c498f to 2090f55 Compare November 17, 2016 11:26
@googlebot
Copy link

CLAs look good, thanks!

@prydonius
Copy link
Member

@k8s-bot ok to test

@viglesiasce
Copy link
Contributor

@foxish can you take a look at this one? The image is not currently pushed either so once if it looks good can you go ahead and push it?

Also keep in mind currently:
#242

@foxish
Copy link
Member

foxish commented Nov 22, 2016

@viglesiasce I'll take a look at it today and push the image as well. Thanks!

@foxish
Copy link
Member

foxish commented Nov 22, 2016

Merge conflicts need to be fixed? @imelnik

@viglesiasce
Copy link
Contributor

Thanks @foxish!

@imelnik the chart changed to the mongodb-replicaset folder so the files will need to be moved.

@zonorti
Copy link
Contributor Author

zonorti commented Nov 23, 2016

@foxish @viglesiasce sure, I would update this PR

@zonorti zonorti force-pushed the mongo-configset-configuration branch 2 times, most recently from 8482159 to 6ddba58 Compare November 23, 2016 10:13
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2016
@zonorti zonorti force-pushed the mongo-configset-configuration branch 3 times, most recently from 7b27fc6 to a0ddd09 Compare November 23, 2016 11:37
@zonorti zonorti force-pushed the mongo-configset-configuration branch from a0ddd09 to a5e1b12 Compare November 24, 2016 09:46
@zonorti
Copy link
Contributor Author

zonorti commented Nov 24, 2016

@k8s-bot e2e test this

@k8s-ci-robot
Copy link
Contributor

@imelnik: you can't request testing unless you are a kubernetes member.

In response to this comment:

@k8s-bot e2e test this

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@zonorti
Copy link
Contributor Author

zonorti commented Nov 28, 2016

@foxish this e2e fail looks like a Jenkins problem
or is there something to fix?

@foxish
Copy link
Member

foxish commented Nov 28, 2016

@k8s-bot e2e test this

@foxish
Copy link
Member

foxish commented Nov 28, 2016

The change LGTM. I'm trying to deploy it once but helm seems to have issues when I have a cluster spun up using Kubernetes release-1.5.

@foxish
Copy link
Member

foxish commented Nov 28, 2016

W1124 01:47:10.109] Error: release mongodb-246 failed: Namespace "pr-master:14bee1e456c1789d1ebdfc2dc7e3ae2b9ea930ce,223:a5e1b12e9605de227f330a40a3dedcd5f1e5c6c2-246" is invalid: [metadata.name: Invalid value: "pr-master:14bee1e456c1789d1ebdfc2dc7e3ae2b9ea930ce,223:a5e1b12e9605de227f330a40a3dedcd5f1e5c6c2-246": must be no more than 63 characters, metadata.name: Invalid value: "pr-master:14bee1e456c1789d1ebdfc2dc7e3ae2b9ea930ce,223:a5e1b12e9605de227f330a40a3dedcd5f1e5c6c2-246": must match the regex a-z0-9? (e.g. 'my-name' or '123-abc')]

@viglesiasce This looks like an e2e testing framework issue. Any ideas why it's picking a large garbled namespace to deploy?

@viglesiasce
Copy link
Contributor

@foxish looks like something has changed on the Jenkins side. The ghprbPullId is now showing as that rather than the PR Id. Will look today.

@viglesiasce
Copy link
Contributor

Opened kubernetes/test-infra#1253, sorry for the churn folks.

@spxtr
Copy link

spxtr commented Dec 1, 2016

@k8s-bot e2e test this

@zonorti
Copy link
Contributor Author

zonorti commented Dec 1, 2016

@viglesiasce thanks for checking tests!

@viglesiasce
Copy link
Contributor

@foxish can you push the image when you get a chance?

@foxish
Copy link
Member

foxish commented Dec 2, 2016

@viglesiasce On it

@foxish
Copy link
Member

foxish commented Dec 2, 2016

gcr.io/google_containers/mongodb-install:0.3
0.3: digest: sha256:46d232cd66435c4ed0565818a45c326b00fa95fe65af171400fc0501b1cd578f size: 1157

Done.

@foxish
Copy link
Member

foxish commented Dec 2, 2016

I still can't test this.
Is there an issue with running helm on the latest master/HEAD?

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"6+", GitVersion:"v1.6.0-alpha.0.986+a2d5df40af698a", GitCommit:"a2d5df40af698a801556f4524a2642e37001e0bb", GitTreeState:"clean", BuildDate:"2016-12-01T21:11:03Z", GoVersion:"go1.7.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"6+", GitVersion:"v1.6.0-alpha.0.986+a2d5df40af698a", GitCommit:"a2d5df40af698a801556f4524a2642e37001e0bb", GitTreeState:"clean", BuildDate:"2016-12-01T21:08:51Z", GoVersion:"go1.7.3", Compiler:"gc", Platform:"linux/amd64"}

$ helm init
$HELM_HOME has been configured at $HOME/.helm.
Warning: Tiller is already installed in the cluster. (Use --client-only to suppress this message.)
Happy Helming!

$ helm version
Client: &version.Version{SemVer:"v2.0.0", GitCommit:"51bdad42756dfaf3234f53ef3d3cb6bcd94144c2", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.0.0", GitCommit:"51bdad42756dfaf3234f53ef3d3cb6bcd94144c2", GitTreeState:"clean"}

$ helm install mongodb-replicaset/
Error: transport is closing

$ helm install mongodb-replicaset/
Error: could not find a ready tiller pod

$ helm version
Client: &version.Version{SemVer:"v2.0.0", GitCommit:"51bdad42756dfaf3234f53ef3d3cb6bcd94144c2", GitTreeState:"clean"}
Error: cannot connect to Tiller

@viglesiasce
Copy link
Contributor

I am able to install on a 1.4.x cluster but seeing the following in the bootstrap init container:

2016/12/02 06:48:16 lookup smelly-indri-mongodb-rep on 10.19.240.10:53: server misbehaving
2016/12/02 06:48:17 lookup smelly-indri-mongodb-rep on 10.19.240.10:53: server misbehaving

@zonorti
Copy link
Contributor Author

zonorti commented Dec 3, 2016

I guess it makes sense to wait till 1.5 release and have it updated at that time

@foxish
Copy link
Member

foxish commented Dec 14, 2016

@imelnik I made a couple of changes to your PR, to work with StatefulSets in k8s1.5. I see the same issue as @viglesiasce did with the bootstrap container. PTAL.

1. The component labels need to match.
2. Changed annotation to alpha from beta
@foxish
Copy link
Member

foxish commented Dec 14, 2016

@imelnik @viglesiasce Pushed commit to fix the issue with bootstrap. It works well on my local setup.
The only update needed is to test.sh, to change the name of the pod from mongodb- to mongodb-rs-.

This is ready for merge once that change is made.

@viglesiasce
Copy link
Contributor

Awesome stuff. Thanks @imelnik and @foxish!!!

@viglesiasce
Copy link
Contributor

@k8s-bot e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins Charts e2e failed for commit afd64d2. Full PR test history.

The magic incantation to run this job again is @k8s-bot e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@foxish
Copy link
Member

foxish commented Dec 19, 2016

@viglesiasce We're not testing on a 1.5 cluster yet? I updated the reference to StatefulSet and that seems to be why it's failing.

@viglesiasce
Copy link
Contributor

Correct. We will move to 1.5 once GKE has it ready. Until then we wont block this (or other SS prs). Once CI is pointing to 1.5 I will send a PR to move this to the stable folder.

@prydonius prydonius merged commit ac24ff8 into helm:master Dec 19, 2016
@zonorti
Copy link
Contributor Author

zonorti commented Dec 20, 2016

@viglesiasce @foxish thanks for updating and megring this one!
I've managed to build one with auto restoring mongo from snapshot, ping me if you think that is worth being public

shubham14bajpai pushed a commit to shubham14bajpai/charts that referenced this pull request Sep 6, 2021
Update with 2.10.0 related YAMLs. 


Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants