-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/airflow] Added resources limit to git-clone initcontainer #22274
Conversation
Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>
Hi @yehlo. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@yehlo: GitHub didn't allow me to assign the following users: gsemet. Note that only helm members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gsemet, yehlo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gsemet @yehlo this is crazy and needs to be reverted, as it will cause extremely large resource requests for the git-clone container. This PR makes the git-clone container resources the same as the scheduler's resources, which is insanity, as most users will have large requests, which are far more than is needed for a git clone Example:
If you wanted to implement this feature you should have used the |
…lm#22274) Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch> Co-authored-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>
…lm#22274) Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch> Co-authored-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>
…lm#22274) Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch> Co-authored-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
…lm#22274) Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch> Co-authored-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Signed-off-by: Joshua Leuenberger joshua.leuenberger@bedag.ch
What this PR does / why we need it:
Git-Clone InitContainers were missing a ressources limitation.
Defaulted it to the main container (eg. scheduler, web...)
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)