Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/airflow] Added resources limit to git-clone initcontainer #22274

Merged
merged 1 commit into from
May 6, 2020
Merged

[stable/airflow] Added resources limit to git-clone initcontainer #22274

merged 1 commit into from
May 6, 2020

Conversation

yehlo
Copy link
Contributor

@yehlo yehlo commented May 6, 2020

Signed-off-by: Joshua Leuenberger joshua.leuenberger@bedag.ch

What this PR does / why we need it:

Git-Clone InitContainers were missing a ressources limitation.
Defaulted it to the main container (eg. scheduler, web...)

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2020
@k8s-ci-robot k8s-ci-robot requested a review from maver1ck May 6, 2020 13:13
@k8s-ci-robot
Copy link
Contributor

Hi @yehlo. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 6, 2020
@yehlo
Copy link
Contributor Author

yehlo commented May 6, 2020

/assign @gsemet
Hi @gsemet, I goofed the rebase and went ahead and recreated a new pull request. Could you take a look at it?
Thanks

@k8s-ci-robot
Copy link
Contributor

@yehlo: GitHub didn't allow me to assign the following users: gsemet.

Note that only helm members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gsemet
Hi @gsemet, I goofed the rebase and went ahead and recreated a new pull request. Could you take a look at it?
Thanks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@gsemet gsemet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gsemet, yehlo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit c5283c7 into helm:master May 6, 2020
@thesuperzapper
Copy link
Contributor

@gsemet @yehlo this is crazy and needs to be reverted, as it will cause extremely large resource requests for the git-clone container.

This PR makes the git-clone container resources the same as the scheduler's resources, which is insanity, as most users will have large requests, which are far more than is needed for a git clone

Example:

requests:
  cpu: "1000m"
  memory: "1Gi"

If you wanted to implement this feature you should have used the {{ .Values.dags.git.gitSync.resources }}, which is what the user specified git-clone container.

irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
…lm#22274)

Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>

Co-authored-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
…lm#22274)

Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>

Co-authored-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
…lm#22274)

Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>

Co-authored-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
…lm#22274)

Signed-off-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>

Co-authored-by: Joshua Leuenberger <joshua.leuenberger@bedag.ch>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants