-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/grafana] Add extraContainerVolumes #22264
[stable/grafana] Add extraContainerVolumes #22264
Conversation
…t as default. Signed-off-by: Chris Downs <downs@mythical.games>
…s, add them to the volumes section of the pod spec Signed-off-by: Chris Downs <downs@mythical.games>
…ADME Signed-off-by: Chris Downs <downs@mythical.games>
Signed-off-by: Chris Downs <downs@mythical.games>
Hi @chris-downs. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rtluckie |
@chris-downs: GitHub didn't allow me to assign the following users: rtluckie. Note that only helm members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chris-downs, zanhsieh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* [stable/grafana] adding extraContainerVolumes variable with empty list as default. Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] if there are volumes defined by extraContainerVolumes, add them to the volumes section of the pod spec Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] documenting new extraContainerVolumes variable in README Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] bumping chart version Signed-off-by: Chris Downs <downs@mythical.games>
* [stable/grafana] adding extraContainerVolumes variable with empty list as default. Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] if there are volumes defined by extraContainerVolumes, add them to the volumes section of the pod spec Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] documenting new extraContainerVolumes variable in README Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] bumping chart version Signed-off-by: Chris Downs <downs@mythical.games>
* [stable/grafana] adding extraContainerVolumes variable with empty list as default. Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] if there are volumes defined by extraContainerVolumes, add them to the volumes section of the pod spec Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] documenting new extraContainerVolumes variable in README Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] bumping chart version Signed-off-by: Chris Downs <downs@mythical.games> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
* [stable/grafana] adding extraContainerVolumes variable with empty list as default. Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] if there are volumes defined by extraContainerVolumes, add them to the volumes section of the pod spec Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] documenting new extraContainerVolumes variable in README Signed-off-by: Chris Downs <downs@mythical.games> * [stable/grafana] bumping chart version Signed-off-by: Chris Downs <downs@mythical.games> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Is this a new chart
No
What this PR does / why we need it:
This PR adds a new
extraContainerVolumes
variable to define arbitrary volumes in the pod spec.The current options for adding additional volumes (
extraVolumeMounts
andextraSecretMounts
) do not allow you to define volumes for a sidecar container without them being automatically mounted in the main grafana container. This is not always desirable as the volumes for the sidecar may contain secrets that should not be exposed to grafana.Example use case with the Google Cloud SQL Proxy:
Which issue this PR fixes
N\A
Special notes for your reviewer:
N\A
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)