Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/airflow] allow specification of probe scheme #22242

Merged
merged 1 commit into from
May 4, 2020
Merged

[stable/airflow] allow specification of probe scheme #22242

merged 1 commit into from
May 4, 2020

Conversation

thesuperzapper
Copy link
Contributor

This PR introduces the ability to specify the probe scheme for livenessProbe and readinessProbe, this is needed to allow users to enable SSL on the Airflow webserver.

It introduces the following values:

  • web.livenessProbe.scheme
  • web.readinessProbe.scheme

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 4, 2020
@k8s-ci-robot k8s-ci-robot requested a review from maver1ck May 4, 2020 07:19
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @thesuperzapper. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2020
@thesuperzapper
[stable/airflow] allow specification of probe scheme
96a51c4 
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2020
@thesuperzapper
Copy link
Contributor Author

@gsemet can you review?

@gsemet
Copy link
Contributor

gsemet commented May 4, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gsemet, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5d826a3 into helm:master May 4, 2020
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@thesuperzapper
[stable/airflow] allow specification of probe scheme (helm#22242)
72ef54e 
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@thesuperzapper @includerandom
[stable/airflow] allow specification of probe scheme (helm#22242)
a0209be 
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@thesuperzapper @li-adrienloiseau
[stable/airflow] allow specification of probe scheme (helm#22242)
dd72484 
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@thesuperzapper
[stable/airflow] allow specification of probe scheme (helm#22242)
8c46e82 
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maver1ck maver1ck Awaiting requested review from maver1ck

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thesuperzapper @k8s-ci-robot @gsemet @helm-bot